[Merged by Bors] - chore(FDeriv/Const): generalize to a TVS#34833
[Merged by Bors] - chore(FDeriv/Const): generalize to a TVS#34833urkud wants to merge 5 commits intoleanprover-community:masterfrom
Conversation
|
@eric-wieser Tagging you to avoid duplication of effort. I'm going to generalize |
PR summary 30e22ac079Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
|
Thanks, I think actually the effort was already duplicated here, but that's my loss for not uploading a draft PR. |
|
This PR/issue depends on:
|
| fderivWithin_const _ | ||
|
|
||
| theorem fderiv_const_apply (c : F) : fderiv 𝕜 (fun _ => c) x = 0 := | ||
| (hasFDerivAt_const c x).fderiv |
There was a problem hiding this comment.
Just to check, this old proof doesn't work any more, even with the other PRs I just merged?
There was a problem hiding this comment.
The old proof would need stronger typeclass assumptions. The new proof uses the fact that 0 is the junk value we use whenever it works to avoid these assumptions.
| .of_isLittleOTVS <| (IsLittleOTVS.zero _ _).congr_left fun _ => by | ||
| simp only [zero_apply, sub_self, Pi.zero_apply] |
There was a problem hiding this comment.
Was this necessary or just golf? Fine either way, but let's mention in the description that some of the changes were golfs and not changes forced by the generalization.
|
bors d+ Thanks! |
|
✌️ urkud can now approve this pull request. To approve and merge a pull request, simply reply with |
|
bors merge |
Proofs about `fderiv`/`fderivWithin` were changed to avoid extra typeclass assumptions. Also replace one `simp only` with `simp`, since the default `simp` set works here.
|
Pull request successfully merged into master. Build succeeded:
|
Proofs about `fderiv`/`fderivWithin` were changed to avoid extra typeclass assumptions. Also replace one `simp only` with `simp`, since the default `simp` set works here.
Proofs about `fderiv`/`fderivWithin` were changed to avoid extra typeclass assumptions. Also replace one `simp only` with `simp`, since the default `simp` set works here.
Proofs about `fderiv`/`fderivWithin` were changed to avoid extra typeclass assumptions. Also replace one `simp only` with `simp`, since the default `simp` set works here.
Proofs about `fderiv`/`fderivWithin` were changed to avoid extra typeclass assumptions. Also replace one `simp only` with `simp`, since the default `simp` set works here.
Proofs about
fderiv/fderivWithinwere changed to avoid extra typeclass assumptions.Also replace one
simp onlywithsimp, since the defaultsimpset works here.