Skip to content

[Merged by Bors] - chore(FDeriv/Const): generalize to a TVS#34833

Closed
urkud wants to merge 5 commits intoleanprover-community:masterfrom
urkud:fderiv-const
Closed

[Merged by Bors] - chore(FDeriv/Const): generalize to a TVS#34833
urkud wants to merge 5 commits intoleanprover-community:masterfrom
urkud:fderiv-const

Conversation

@urkud
Copy link
Copy Markdown
Member

@urkud urkud commented Feb 4, 2026

Proofs about fderiv/fderivWithin were changed to avoid extra typeclass assumptions.

Also replace one simp only with simp, since the default simp set works here.


Open in Gitpod

@urkud urkud marked this pull request as draft February 4, 2026 09:19
@urkud
Copy link
Copy Markdown
Member Author

urkud commented Feb 4, 2026

@eric-wieser Tagging you to avoid duplication of effort. I'm going to generalize Congr tomorrow.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 4, 2026

PR summary 30e22ac079

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-analysis Analysis (normed *, calculus) label Feb 4, 2026
@eric-wieser
Copy link
Copy Markdown
Member

Thanks, I think actually the effort was already duplicated here, but that's my loss for not uploading a draft PR.

@urkud urkud changed the title chore(FDeriv/Const): generalize most of the file to a TVS chore(FDeriv/Const): generalize to a TVS Feb 4, 2026
@mathlib-dependent-issues mathlib-dependent-issues bot added blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) and removed blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) labels Feb 4, 2026
@mathlib-dependent-issues
Copy link
Copy Markdown

This PR/issue depends on:

@urkud urkud marked this pull request as ready for review February 4, 2026 19:28
@urkud urkud requested a review from eric-wieser February 4, 2026 19:29
fderivWithin_const _

theorem fderiv_const_apply (c : F) : fderiv 𝕜 (fun _ => c) x = 0 :=
(hasFDerivAt_const c x).fderiv
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to check, this old proof doesn't work any more, even with the other PRs I just merged?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The old proof would need stronger typeclass assumptions. The new proof uses the fact that 0 is the junk value we use whenever it works to avoid these assumptions.

Comment on lines -40 to -41
.of_isLittleOTVS <| (IsLittleOTVS.zero _ _).congr_left fun _ => by
simp only [zero_apply, sub_self, Pi.zero_apply]
Copy link
Copy Markdown
Member

@eric-wieser eric-wieser Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this necessary or just golf? Fine either way, but let's mention in the description that some of the changes were golfs and not changes forced by the generalization.

@eric-wieser
Copy link
Copy Markdown
Member

bors d+

Thanks!

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Feb 4, 2026

✌️ urkud can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@mathlib-triage mathlib-triage bot added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Feb 4, 2026
@urkud
Copy link
Copy Markdown
Member Author

urkud commented Feb 4, 2026

bors merge

@mathlib-triage mathlib-triage bot added the ready-to-merge This PR has been sent to bors. label Feb 4, 2026
mathlib-bors bot pushed a commit that referenced this pull request Feb 5, 2026
Proofs about `fderiv`/`fderivWithin` were changed to avoid extra typeclass assumptions.

Also replace one `simp only` with `simp`, since the default `simp` set works here.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Feb 5, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(FDeriv/Const): generalize to a TVS [Merged by Bors] - chore(FDeriv/Const): generalize to a TVS Feb 5, 2026
@mathlib-bors mathlib-bors bot closed this Feb 5, 2026
zhuyizheng pushed a commit to zhuyizheng/mathlib4 that referenced this pull request Feb 5, 2026
Proofs about `fderiv`/`fderivWithin` were changed to avoid extra typeclass assumptions.

Also replace one `simp only` with `simp`, since the default `simp` set works here.
@urkud urkud deleted the fderiv-const branch February 5, 2026 02:53
michaellee94 pushed a commit to michaellee94/mathlib4 that referenced this pull request Feb 15, 2026
Proofs about `fderiv`/`fderivWithin` were changed to avoid extra typeclass assumptions.

Also replace one `simp only` with `simp`, since the default `simp` set works here.
Maldooor pushed a commit to Maldooor/mathlib4 that referenced this pull request Feb 25, 2026
Proofs about `fderiv`/`fderivWithin` were changed to avoid extra typeclass assumptions.

Also replace one `simp only` with `simp`, since the default `simp` set works here.
pfaffelh pushed a commit to pfaffelh/mathlib4 that referenced this pull request Mar 2, 2026
Proofs about `fderiv`/`fderivWithin` were changed to avoid extra typeclass assumptions.

Also replace one `simp only` with `simp`, since the default `simp` set works here.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). ready-to-merge This PR has been sent to bors. t-analysis Analysis (normed *, calculus)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants