[Merged by Bors] - feat: Bird–Wadler duality theorems#35713
[Merged by Bors] - feat: Bird–Wadler duality theorems#35713Parcly-Taxel wants to merge 16 commits intoleanprover-community:masterfrom
Conversation
PR summary 7d9358ee9dImport changes for modified filesNo significant changes to the import graph Import changes for all files
|
Vierkantor
left a comment
There was a problem hiding this comment.
I like that this gives us a consistent set of theorems about foldl/foldr. The name for this file is not completely obvious to me: I don't associate foldl_eq_foldr with "Bird-Wadler duality", and the phrase "Bird-Wadler duality" doesn't give me any search results. Maybe Data/List/Fold.lean would be a good name? (This doesn't really apply to the module doc since it has a good explanation of why we use this name.)
Vierkantor
left a comment
There was a problem hiding this comment.
Thanks for making the changes!
bors d+
|
✌️ Parcly-Taxel can now approve this pull request. To approve and merge a pull request, simply reply with |
Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
|
bors merge |
Forms of these three theorems already exist in mathlib and the Lean standard library, but they are scattered about. Bring them together in one file, deprecating the _ad hoc_ names for the first and second theorems. Co-authored-by: Parcly Taxel <reddeloostw@gmail.com> Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
|
Pull request successfully merged into master. Build succeeded: |
Forms of these three theorems already exist in mathlib and the Lean standard library, but they are scattered about. Bring them together in one file, deprecating the ad hoc names for the first and second theorems.