Skip to content

feat(RingTheory/Flat): finite flat algebra is trivial if rank is equal to 1#36399

Open
chrisflav wants to merge 7 commits intoleanprover-community:masterfrom
chrisflav:flat-rank
Open

feat(RingTheory/Flat): finite flat algebra is trivial if rank is equal to 1#36399
chrisflav wants to merge 7 commits intoleanprover-community:masterfrom
chrisflav:flat-rank

Conversation

@chrisflav
Copy link
Copy Markdown
Member

@chrisflav chrisflav commented Mar 9, 2026

From Pi1.


Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 9, 2026

PR summary 3bd2603b81

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.RingTheory.Flat.Rank (new file) 2130

Declarations diff

+ Module.Flat.tfae_algebraMap_surjective
+ Module.Free.bijective_algebraMap_of_finrank_eq_one
+ Module.algebraMap_bijective_iff_rankAtStalk
+ Module.algebraMap_bijective_of_rankAtStalk
+ Module.algebraMap_surjective_of_rankAtStalk_le_one
+ Module.rankAtStalk_le_one_iff_surjective
+ Module.rankAtStalk_pos_iff_algebraMap_injective
+ PrimeSpectrum.comap_surjective_iff_injective_of_finite
+ PrimeSpectrum.rankAtStalk_pos_iff_comap_surjective
+ PrimeSpectrum.rankAtStalk_pos_iff_mem_range_comap
+ _root_.Algebra.IsIntegral.comap_surjective
+ instance {T : Type*} [CommSemiring T] [Algebra R T] :
+ mul'_bijective_of_surjective

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


Increase in tech debt: (relative, absolute) = (1.00, 0.00)
Current number Change Type
6900 1 backward.isDefEq.respectTransparency

Current commit 6a03db0720
Reference commit 3bd2603b81

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@robin-carlier robin-carlier added the awaiting-author A reviewer has asked the author a question or requested changes. label Apr 3, 2026
chrisflav and others added 6 commits April 3, 2026 14:08
Co-authored-by: Robin Carlier <57142648+robin-carlier@users.noreply.github.com>
Co-authored-by: Robin Carlier <57142648+robin-carlier@users.noreply.github.com>
Co-authored-by: Robin Carlier <57142648+robin-carlier@users.noreply.github.com>
Co-authored-by: Robin Carlier <57142648+robin-carlier@users.noreply.github.com>
@chrisflav
Copy link
Copy Markdown
Member Author

Thanks for the review @robin-carlier!

@chrisflav chrisflav added awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. and removed awaiting-author A reviewer has asked the author a question or requested changes. labels Apr 3, 2026
@github-actions github-actions bot removed the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Apr 3, 2026
@robin-carlier
Copy link
Copy Markdown
Contributor

Thanks!

maintainer merge

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 3, 2026

🚀 Pull request has been placed on the maintainer queue by robin-carlier.

@mathlib-triage mathlib-triage bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Apr 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. t-ring-theory Ring theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants