Skip to content

[Merged by Bors] - feat(GroupTheory/IndexNSmul): add results on multiplication-by-n in AddCommGroups#36494

Closed
MichaelStollBayreuth wants to merge 20 commits intoleanprover-community:masterfrom
MichaelStollBayreuth:MS_API_index_2
Closed

[Merged by Bors] - feat(GroupTheory/IndexNSmul): add results on multiplication-by-n in AddCommGroups#36494
MichaelStollBayreuth wants to merge 20 commits intoleanprover-community:masterfrom
MichaelStollBayreuth:MS_API_index_2

Conversation

@MichaelStollBayreuth
Copy link
Copy Markdown
Contributor

@MichaelStollBayreuth MichaelStollBayreuth commented Mar 11, 2026

This PR adds a new file (to be able to have the required imports) that contains some results related to the (relative) index of subgroups in commutative additive groups and the multiplication-by-n map.

They will be useful in proving the Northcott property for heights on number fields.


Open in Gitpod

@MichaelStollBayreuth MichaelStollBayreuth added the t-algebra Algebra (groups, rings, fields, etc) label Mar 11, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 11, 2026

PR summary 0692ef80fb

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.GroupTheory.IndexNSmul (new file) 1414

Declarations diff

+ distribSMulToLinearMap_injective_of_isTorsionFree
+ finrank_eq_of_finiteIndex
+ finrank_eq_of_isFiniteRelIndex
+ index_range_nsmul
+ nsmulAddMonoidHom_injective_of_isTorsionFree
+ relIndex_map_nsmul

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@mathlib-dependent-issues mathlib-dependent-issues bot added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Mar 11, 2026
@mathlib-dependent-issues mathlib-dependent-issues bot removed the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Mar 26, 2026
@mathlib-dependent-issues
Copy link
Copy Markdown

This PR/issue depends on:

@artie2000
Copy link
Copy Markdown
Collaborator

could you provide a more descriptive name for the PR?

@MichaelStollBayreuth
Copy link
Copy Markdown
Contributor Author

Is the PR description not good enough?

@artie2000
Copy link
Copy Markdown
Collaborator

it's so people (like me) skimming the review queue can quickly decide whether we will understand the maths in your PR and decide to review it (or not)

@MichaelStollBayreuth MichaelStollBayreuth changed the title feat(GroupTheory/IndexNSmul): new file feat(GroupTheory/IndexNSmul): add results on multiplication-by-n in AddCommGroups Apr 2, 2026
@dagurtomas dagurtomas added the awaiting-author A reviewer has asked the author a question or requested changes. label Apr 2, 2026
@MichaelStollBayreuth MichaelStollBayreuth removed the awaiting-author A reviewer has asked the author a question or requested changes. label Apr 2, 2026
@dagurtomas dagurtomas added the awaiting-author A reviewer has asked the author a question or requested changes. label Apr 9, 2026
@MichaelStollBayreuth MichaelStollBayreuth removed the awaiting-author A reviewer has asked the author a question or requested changes. label Apr 9, 2026
@dagurtomas
Copy link
Copy Markdown
Contributor

Thanks!

maintainer merge

@github-actions
Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by dagurtomas.

@mathlib-triage mathlib-triage bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Apr 10, 2026
@riccardobrasca
Copy link
Copy Markdown
Member

Thanks!

bors merge

@mathlib-triage mathlib-triage bot added ready-to-merge This PR has been sent to bors. and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Apr 10, 2026
mathlib-bors bot pushed a commit that referenced this pull request Apr 10, 2026
…ddCommGroups (#36494)

This PR adds a new file (to be able to have the required imports) that contains some results related to the (relative) index of subgroups in commutative additive groups and the multiplication-by-`n` map.

They will be useful in proving the Northcott property for heights on number fields.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Apr 10, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(GroupTheory/IndexNSmul): add results on multiplication-by-n in AddCommGroups [Merged by Bors] - feat(GroupTheory/IndexNSmul): add results on multiplication-by-n in AddCommGroups Apr 10, 2026
@mathlib-bors mathlib-bors bot closed this Apr 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants