Skip to content

[Merged by Bors] - feat(Data/Finsupp): add lemmas for Finsupp and Sum#36506

Closed
BryceT233 wants to merge 30 commits intoleanprover-community:masterfrom
BryceT233:MvPowerSeries_Equiv_prep
Closed

[Merged by Bors] - feat(Data/Finsupp): add lemmas for Finsupp and Sum#36506
BryceT233 wants to merge 30 commits intoleanprover-community:masterfrom
BryceT233:MvPowerSeries_Equiv_prep

Conversation

@BryceT233
Copy link
Copy Markdown
Contributor

This PR adds various computational lemmas related to operations of finitely supported functions. Alongside #35329, theses lemmas provide the necessary helpers to construct various equivalences for MvPowerSeries.


Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 12, 2026

PR summary 08fd1302b1

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ comapDomain_inl_sumElim
+ comapDomain_inr_sumElim
+ comapDomain_sumElim_comapDomain
+ embDomain_inl
+ embDomain_inr
+ image_sumElim_product_antidiagonal
+ optionElim_add
+ sumElim_add

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-data Data (lists, quotients, numbers, etc) label Mar 12, 2026
@Vierkantor Vierkantor changed the title feat(Data/Finsupp): adds various computational lemmas for Finsupp feat(Data/Finsupp): add various computational lemmas for Finsupp Mar 26, 2026
Copy link
Copy Markdown
Contributor

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few remarks but overall this looks useful, thanks for covering this area! 🎉

@Vierkantor Vierkantor changed the title feat(Data/Finsupp): add various computational lemmas for Finsupp feat(Data/Finsupp): add lemmas for Finsupp and Sum Mar 26, 2026
@Vierkantor Vierkantor added the awaiting-author A reviewer has asked the author a question or requested changes. label Mar 26, 2026
@BryceT233
Copy link
Copy Markdown
Contributor Author

Thanks for the review! I applied the suggestions, but currently the lint style check fails due to some windows line endings issues and I am trying to fix it.

@BryceT233
Copy link
Copy Markdown
Contributor Author

It looks like an auto-fix script ran and somehow rewrote the entire file when I was testing.

@BryceT233
Copy link
Copy Markdown
Contributor Author

I tried reverting my changes to Basic.lean and Option.lean, but GitHub is still showing them as modified in the diff. Additionally, the lint error regarding windows line endings (CRLF) is still persisting. I'd really appreciate some guidance on how to get these issues resolved! Maybe I should reopen the PR? Thanks!

@BryceT233
Copy link
Copy Markdown
Contributor Author

-awaiting-author

@github-actions github-actions bot removed the awaiting-author A reviewer has asked the author a question or requested changes. label Apr 1, 2026
Copy link
Copy Markdown
Contributor

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad to see that you managed to figure out the accidental changes, sadly I was busy with other work and couldn't take a look at it until now.

Thank you for the PR!

bors r+

@mathlib-triage mathlib-triage bot added the ready-to-merge This PR has been sent to bors. label Apr 2, 2026
mathlib-bors bot pushed a commit that referenced this pull request Apr 2, 2026
This PR adds various computational lemmas related to operations of finitely supported functions. Alongside #35329, theses lemmas provide the necessary helpers to construct various equivalences for `MvPowerSeries`.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Apr 2, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Data/Finsupp): add lemmas for Finsupp and Sum [Merged by Bors] - feat(Data/Finsupp): add lemmas for Finsupp and Sum Apr 2, 2026
@mathlib-bors mathlib-bors bot closed this Apr 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-data Data (lists, quotients, numbers, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants