Skip to content

[Merged by Bors] - feat: lemmas on ordinal Nat.cast#36584

Closed
vihdzp wants to merge 9 commits intoleanprover-community:masterfrom
vihdzp:ordinalnat
Closed

[Merged by Bors] - feat: lemmas on ordinal Nat.cast#36584
vihdzp wants to merge 9 commits intoleanprover-community:masterfrom
vihdzp:ordinalnat

Conversation

@vihdzp
Copy link
Copy Markdown
Collaborator

@vihdzp vihdzp commented Mar 13, 2026

Downstreamed from the CGT repo.


Open in Gitpod

@vihdzp vihdzp requested a review from SnirBroshi March 13, 2026 04:45
@github-actions github-actions bot added merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) t-set-theory Set theory labels Mar 13, 2026
@github-actions github-actions bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Mar 13, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 13, 2026

PR summary 4ec5d95aa6

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ eq_natCast_of_le_natCast
+ eq_natCast_or_omega0_le
+ natCast_image_Iio

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Co-authored-by: Snir Broshi <26556598+SnirBroshi@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@b-mehta b-mehta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note there's a merge conflict.
Other than that, and the comment above, looks good.

@b-mehta b-mehta self-assigned this Mar 15, 2026
@mathlib-merge-conflicts mathlib-merge-conflicts bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Mar 15, 2026
@mathlib-merge-conflicts
Copy link
Copy Markdown

This pull request has conflicts, please merge master and resolve them.

@github-actions github-actions bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Mar 15, 2026
@vihdzp vihdzp requested a review from b-mehta April 2, 2026 16:14
Copy link
Copy Markdown
Contributor

@b-mehta b-mehta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors merge

@mathlib-triage mathlib-triage bot added the ready-to-merge This PR has been sent to bors. label Apr 2, 2026
mathlib-bors bot pushed a commit that referenced this pull request Apr 2, 2026
Downstreamed from the CGT repo.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Apr 2, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: lemmas on ordinal Nat.cast [Merged by Bors] - feat: lemmas on ordinal Nat.cast Apr 2, 2026
@mathlib-bors mathlib-bors bot closed this Apr 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-set-theory Set theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants