[Merged by Bors] - feat(Combinatorics/SimpleGraph/Walk/Operations): clean up append/concat#36705
Closed
SnirBroshi wants to merge 5 commits intoleanprover-community:masterfrom
Closed
Conversation
…port and cleaning up append/concat
PR summary 63486b57caImport changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diff
You can run this locally as follows## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
mathlib-merge-conflicts
bot
added
the
merge-conflict
|
This pull request has conflicts, please merge |
github-actions
bot
removed
the
merge-conflict
Collaborator
|
Thank you for the PR! :) Could you split off the cleanup part into separate chore PRs? It would be very useful for a chore PR to replace all occurrences of Please also add a descriptive PR description. |
ooovi
added
the
awaiting-author
SnirBroshi
removed
the
awaiting-author
SnirBroshi
changed the title
Contributor
|
Nice, thank you! bors merge |
Contributor
|
Merge conflict. |
Contributor
|
bors d+ |
Contributor
|
✌️ SnirBroshi can now approve this pull request. To approve and merge a pull request, simply reply with |
mathlib-triage
bot
added
the
delegated
SnirBroshi
changed the title
Collaborator
Author
|
bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Apr 1, 2026
…at (#36705) `_ ++ [_]` is the simpNF of `List.concat _ _`.
Contributor
|
This PR was included in a batch that was canceled, it will be automatically retried |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Apr 1, 2026
…at (#36705) `_ ++ [_]` is the simpNF of `List.concat _ _`.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
aditya-ramabadran
pushed a commit
to aditya-ramabadran/mathlib4
that referenced
this pull request
Apr 1, 2026
…at (leanprover-community#36705) `_ ++ [_]` is the simpNF of `List.concat _ _`.
xroblot
pushed a commit
to xroblot/mathlib4
that referenced
this pull request
Apr 3, 2026
…at (leanprover-community#36705) `_ ++ [_]` is the simpNF of `List.concat _ _`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_ ++ [_]is the simpNF ofList.concat _ _.This follows the feedback from #35630 (comment) and #35631 (comment)