Skip to content

[Merged by Bors] - feat(Data/ENat): more lemma about WithBot ENat#36817

Closed
Thmoas-Guan wants to merge 12 commits intoleanprover-community:masterfrom
Thmoas-Guan:more-WithBot-ENat-lemma
Closed

[Merged by Bors] - feat(Data/ENat): more lemma about WithBot ENat#36817
Thmoas-Guan wants to merge 12 commits intoleanprover-community:masterfrom
Thmoas-Guan:more-WithBot-ENat-lemma

Conversation

@Thmoas-Guan
Copy link
Copy Markdown
Collaborator

@Thmoas-Guan Thmoas-Guan commented Mar 18, 2026

In this PR, we add some lemma about WithBot ENat found useful in dimension shifting.

Co-authored-by: Yimin Fu fakegreenall@foxmail.com


Open in Gitpod

@github-actions github-actions bot added the t-algebra Algebra (groups, rings, fields, etc) label Mar 18, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 18, 2026

PR summary 4ec5d95aa6

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ add_one_le_iff'
+ add_one_le_natCast_iff
+ add_one_le_zero_iff
+ coe_eq_natCast
+ lt_zero_iff_eq_bot

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@dagurtomas dagurtomas added the awaiting-author A reviewer has asked the author a question or requested changes. label Mar 26, 2026
@Thmoas-Guan Thmoas-Guan removed the awaiting-author A reviewer has asked the author a question or requested changes. label Mar 27, 2026
Copy link
Copy Markdown
Contributor

@dagurtomas dagurtomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maintainer delegate

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 2, 2026

🚀 Pull request has been placed on the maintainer queue by dagurtomas.

@mathlib-triage mathlib-triage bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Apr 2, 2026
Copy link
Copy Markdown
Contributor

@ocfnash ocfnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Apr 2, 2026

✌️ Thmoas-Guan can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@mathlib-triage mathlib-triage bot added delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Apr 2, 2026
@Thmoas-Guan
Copy link
Copy Markdown
Collaborator Author

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Apr 2, 2026
In this PR, we add some lemma about WithBot ENat found useful in dimension shifting.

Co-authored-by: Yimin Fu <fakegreenall@foxmail.com>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Apr 2, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Data/ENat): more lemma about WithBot ENat [Merged by Bors] - feat(Data/ENat): more lemma about WithBot ENat Apr 2, 2026
@mathlib-bors mathlib-bors bot closed this Apr 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants