-
Notifications
You must be signed in to change notification settings - Fork 1.2k
refactor: Language as a one-field structure
#36934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Parcly-Taxel
wants to merge
10
commits into
leanprover-community:master
Choose a base branch
from
Parcly-Taxel:language1fs
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
3a7d42c
initial
Parcly-Taxel 83663d8
fix
Parcly-Taxel 50f1f48
Merge branch 'master' into language1fs
Parcly-Taxel 752ba8d
fix 2
Parcly-Taxel e06b5e6
fix 3
Parcly-Taxel 7f5a4f3
Merge branch 'master' into language1fs
Parcly-Taxel 01eb2be
Merge branch 'master' into language1fs
Parcly-Taxel b9809ef
Apply suggestions from code review
Parcly-Taxel a9b45ab
fix
Parcly-Taxel a03de40
fix 2
Parcly-Taxel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -136,8 +136,9 @@ def Generates (g : ContextFreeGrammar T) (s : List (Symbol T g.NT)) : Prop := | |
| g.Derives [Symbol.nonterminal g.initial] s | ||
|
|
||
| /-- The language (set of words) that can be generated by a given context-free grammar `g`. -/ | ||
| @[simps] | ||
| def language (g : ContextFreeGrammar T) : Language T := | ||
| { w : List T | g.Generates (w.map Symbol.terminal) } | ||
| ⟨{w | g.Generates (w.map Symbol.terminal)}⟩ | ||
|
|
||
| /-- A given word `w` belongs to the language generated by a given context-free grammar `g` iff | ||
| `g` can derive the word `w` (wrapped as a string) from the initial nonterminal of `g` in some | ||
|
|
@@ -231,7 +232,10 @@ lemma derives_nonterminal {t : g.NT} (hgt : ∀ r ∈ g.rules, r.input ≠ t) | |
| tauto | ||
|
|
||
| lemma language_eq_zero_of_forall_input_ne_initial (hg : ∀ r ∈ g.rules, r.input ≠ g.initial) : | ||
| g.language = 0 := by ext; simp +contextual [derives_nonterminal, hg] | ||
| g.language = 0 := by | ||
| ext | ||
| simp only [Language.zero_def, language, Set.mem_empty_iff_false, iff_false] | ||
| exact derives_nonterminal hg _ (by simp) | ||
|
|
||
| end ContextFreeGrammar | ||
|
|
||
|
|
@@ -328,7 +332,9 @@ alias ⟨_, Generates.reverse⟩ := generates_reverse | |
| @[simp] lemma generates_reverse_comm : g.reverse.Generates u ↔ g.Generates u.reverse := by | ||
| simp [Generates] | ||
|
|
||
| @[simp] lemma language_reverse : g.reverse.language = g.language.reverse := by ext; simp | ||
| @[simp] lemma language_reverse : g.reverse.language = g.language.reverse := by | ||
| ext | ||
| simp [language, Language.reverse_eq_image, List.reverse_eq_iff] | ||
|
Comment on lines
+335
to
+337
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If you've set things up correctly, then this proof shouldn't need changing |
||
|
|
||
| end ContextFreeGrammar | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.