[Merged by Bors] - ci: update splice-bot, enable splice-bot merge#36935
Closed
bryangingechen wants to merge 1 commit intoleanprover-community:masterfrom
Closed
[Merged by Bors] - ci: update splice-bot, enable splice-bot merge#36935bryangingechen wants to merge 1 commit intoleanprover-community:masterfrom
bryangingechen wants to merge 1 commit intoleanprover-community:masterfrom
Conversation
PR summary 61155454e5Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
Workflow documentation reminderThis PR modifies files under Modified workflow files:
|
github-actions
bot
added
the
CI
bryangingechen
commented
Mar 21, 2026
| source_workflow: ${{ github.event.workflow_run.name }} | ||
| push_to_fork: leanprover-community/mathlib4_copy | ||
| min_repo_permission: 'write' | ||
| min_repo_permission: 'disabled' |
Contributor
Author
There was a problem hiding this comment.
This simplifies permissions slightly; now the command is restricted to the allowed teams only and doessn't check repo roles.
joneugster
approved these changes
Mar 27, 2026
Contributor
joneugster
left a comment
joneugster
left a comment
There was a problem hiding this comment.
I have nothing to add, thanks for the PR!
maintainer merge
|
🚀 Pull request has been placed on the maintainer queue by joneugster. |
mathlib-triage
bot
added
the
maintainer-merge
Contributor
|
Thanks! I'll delegate, so, once you merge, you can quickly test! bors d+ |
Contributor
|
✌️ bryangingechen can now approve this pull request. To approve and merge a pull request, simply reply with |
mathlib-triage
bot
added
delegated
Contributor
Author
|
bors r+ |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Mar 28, 2026
This bumps the version of the SpliceBot ([changes](leanprover-community/SpliceBot@146ee71...a463ae1)) to include support for "label commands" and gives `mathlib-splicebot` the ability to use the `auto-merge-after-CI` label. After this is merged, maintainers will be able to type `splice-bot merge` in a pull request review comment and the splicebot will do its thing, and also apply the `auto-merge-after-CI` label, which will cause the PR to be merged if CI passes. Note that this also makes normal usage stricter -- `splice-bot trailing text` will be interpreted as a label command, and will fail. The `label_command` input is set to a repo variable so that we can adjust it if needed without opening a PR. For now I have added the following in the `SPLICEBOT_LABEL_COMMANDS` variable: ```json [ { "command": "merge", "label": "auto-merge-after-CI", "min_repo_permission": "disabled", "allowed_teams": ["leanprover-community/mathlib-maintainers"] } ] ```
Contributor
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This bumps the version of the SpliceBot (changes) to include support for "label commands" and gives
mathlib-splicebotthe ability to use theauto-merge-after-CIlabel.After this is merged, maintainers will be able to type
splice-bot mergein a pull request review comment and the splicebot will do its thing, and also apply theauto-merge-after-CIlabel, which will cause the PR to be merged if CI passes. Note that this also makes normal usage stricter --splice-bot trailing textwill be interpreted as a label command, and will fail.The
label_commandinput is set to a repo variable so that we can adjust it if needed without opening a PR. For now I have added the following in theSPLICEBOT_LABEL_COMMANDSvariable:[ { "command": "merge", "label": "auto-merge-after-CI", "min_repo_permission": "disabled", "allowed_teams": ["leanprover-community/mathlib-maintainers"] } ]