Skip to content

feat(AlgebraicTopology): SimplexCategory.toTop_map_δ_apply#37057

Open
erdOne wants to merge 7 commits intoleanprover-community:masterfrom
erdOne:erd1/toTop_map_δ_apply

Hidden character warning

The head ref may contain hidden characters: "erd1/toTop_map_\u03b4_apply"
Open

feat(AlgebraicTopology): SimplexCategory.toTop_map_δ_apply#37057
erdOne wants to merge 7 commits intoleanprover-community:masterfrom
erdOne:erd1/toTop_map_δ_apply

Conversation

@erdOne
Copy link
Copy Markdown
Member

@erdOne erdOne commented Mar 23, 2026


Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 23, 2026

PR summary 5289bf289a

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ _root_.stdSimplex.map_δ_apply
+ castSucc_eq_zero
+ succAbove_eq_iff
+ succAbove_eq_zero
+ toTop_map_δ_apply
+ δ_apply
+ σ_apply

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 23, 2026

✅ PR Title Formatted Correctly

The title of this PR has been updated to match our commit style conventions.
Thank you!

@erdOne erdOne force-pushed the erd1/toTop_map_δ_apply branch from 454ac5e to 81865a4 Compare March 23, 2026 20:00
@erdOne erdOne changed the title Erd1/toTop map δ apply feat(AlgebraicTopology): SimplexCategory.toTop_map_δ_apply Mar 23, 2026
@mathlib-merge-conflicts mathlib-merge-conflicts bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Mar 25, 2026
@mathlib-merge-conflicts
Copy link
Copy Markdown

This pull request has conflicts, please merge master and resolve them.

@github-actions github-actions bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Mar 27, 2026
@Raph-DG
Copy link
Copy Markdown
Collaborator

Raph-DG commented Mar 31, 2026

awaiting-author

@github-actions github-actions bot added the awaiting-author A reviewer has asked the author a question or requested changes. label Mar 31, 2026
erdOne added 2 commits April 1, 2026 11:05
…lib4 into erd1/toTop_map_δ_apply

:wpecially if it merges an updated upstream into a topic branch.
@erdOne erdOne added awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. t-algebraic-topology Algebraic topology and removed awaiting-author A reviewer has asked the author a question or requested changes. labels Apr 1, 2026
@github-actions github-actions bot removed the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Apr 1, 2026
@dagurtomas dagurtomas self-requested a review April 2, 2026 14:56
Copy link
Copy Markdown
Contributor

@dagurtomas dagurtomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

maintainer merge

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 2, 2026

🚀 Pull request has been placed on the maintainer queue by dagurtomas.

@mathlib-triage mathlib-triage bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Apr 2, 2026
lemma concreteCategoryHom_id (n : SimplexCategory) : ConcreteCategory.hom (𝟙 n) = .id := rfl

@[simp]
lemma δ_apply {n : ℕ} (i : Fin (n + 2)) (j : Fin (⦋n⦌.len + 1)) : δ i j = i.succAbove j := rfl
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works also fine:

Suggested change
lemma δ_apply {n : ℕ} (i : Fin (n + 2)) (j : Fin (⦋n⦌.len + 1)) : δ i j = i.succAbove j := rfl
lemma δ_apply {n : ℕ} (i : Fin (n + 2)) (j : Fin (n + 1)) : δ i j = i.succAbove j := rfl

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not reducibly type correct because currently ⦋n⦌.len is not reducibly defeq to n and it causes troubles especially with the new transparency changes.

Comment on lines +56 to +60
lemma _root_.stdSimplex.map_δ_apply {n : ℕ} (i : Fin (n + 2)) (j : Fin (⦋n + 1⦌.len + 1))
(σ : stdSimplex ℝ (Fin (⦋n⦌.len + 1))) :
stdSimplex.map (SimplexCategory.δ i) σ j =
(if i < j then σ ⟨j - 1, by simpa using j.2⟩ else 0) +
(if h : i > j then σ ⟨j, by simp_all; lia⟩ else 0) := by
Copy link
Copy Markdown
Contributor

@joelriou joelriou Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
lemma _root_.stdSimplex.map_δ_apply {n : ℕ} (i : Fin (n + 2)) (j : Fin (n + 1⦌.len + 1))
(σ : stdSimplex ℝ (Fin (⦋n⦌.len + 1))) :
stdSimplex.map (SimplexCategory.δ i) σ j =
(if i < j then σ ⟨j - 1, by simpa using j.2else 0) +
(if h : i > j then σ ⟨j, by simp_all; lia⟩ else 0) := by
lemma _root_.stdSimplex.map_δ_apply {n : ℕ} (i j : Fin (n + 2))
(σ : stdSimplex ℝ (Fin (⦋n⦌.len + 1))) :
stdSimplex.map (SimplexCategory.δ i) σ j =
(if i < j then σ ⟨j - 1, by simp_all; liaelse 0) +
(if h : i > j then σ ⟨j, by simp_all; lia⟩ else 0) := by

@joelriou joelriou added the awaiting-author A reviewer has asked the author a question or requested changes. label Apr 2, 2026
@erdOne erdOne removed the awaiting-author A reviewer has asked the author a question or requested changes. label Apr 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. t-algebraic-topology Algebraic topology

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants