Skip to content

[Merged by Bors] - chore(LinearAlgebra/ExteriorPower/Basis): avoid use of IsWellFounded.wellOrderExtension#37078

Closed
vihdzp wants to merge 3 commits intoleanprover-community:masterfrom
vihdzp:well
Closed

[Merged by Bors] - chore(LinearAlgebra/ExteriorPower/Basis): avoid use of IsWellFounded.wellOrderExtension#37078
vihdzp wants to merge 3 commits intoleanprover-community:masterfrom
vihdzp:well

Conversation

@vihdzp
Copy link
Copy Markdown
Collaborator

@vihdzp vihdzp commented Mar 24, 2026

This file formerly used IsWellFounded.wellOrderExtension on an empty relation to create a linear order extending it, i.e. an arbitrary linear order. But we can accomplish this directly via the well-ordering principle.


Open in Gitpod

@vihdzp vihdzp added the easy < 20s of review time. See the lifecycle page for guidelines. label Mar 24, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 24, 2026

PR summary 4ec5d95aa6

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.LinearAlgebra.ExteriorPower.Basis 1615 1613 -2 (-0.12%)
Import changes for all files
Files Import difference
Mathlib.LinearAlgebra.ExteriorAlgebra.Basis Mathlib.LinearAlgebra.ExteriorPower.Basis -2

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-algebra Algebra (groups, rings, fields, etc) label Mar 24, 2026
@dagurtomas
Copy link
Copy Markdown
Contributor

maintainer merge

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 2, 2026

🚀 Pull request has been placed on the maintainer queue by dagurtomas.

@mathlib-triage mathlib-triage bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Apr 2, 2026
@ocfnash
Copy link
Copy Markdown
Contributor

ocfnash commented Apr 2, 2026

Please apply the suggestions and then feel free to merge!

bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Apr 2, 2026

✌️ vihdzp can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@mathlib-triage mathlib-triage bot added delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Apr 2, 2026
@vihdzp
Copy link
Copy Markdown
Collaborator Author

vihdzp commented Apr 2, 2026

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Apr 2, 2026
…wellOrderExtension (#37078)

This file formerly used `IsWellFounded.wellOrderExtension` on an empty relation to create a linear order extending it, i.e. an arbitrary linear order. But we can accomplish this directly via the well-ordering principle.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Apr 2, 2026

Build failed (retrying...):

mathlib-bors bot pushed a commit that referenced this pull request Apr 2, 2026
…wellOrderExtension (#37078)

This file formerly used `IsWellFounded.wellOrderExtension` on an empty relation to create a linear order extending it, i.e. an arbitrary linear order. But we can accomplish this directly via the well-ordering principle.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Apr 2, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(LinearAlgebra/ExteriorPower/Basis): avoid use of IsWellFounded.wellOrderExtension [Merged by Bors] - chore(LinearAlgebra/ExteriorPower/Basis): avoid use of IsWellFounded.wellOrderExtension Apr 2, 2026
@mathlib-bors mathlib-bors bot closed this Apr 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). easy < 20s of review time. See the lifecycle page for guidelines. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants