[Merged by Bors] - feat(Algebra/ModuleCat): lemma for projective dimension eq zero #37351
Closed
Thmoas-Guan wants to merge 6 commits intoleanprover-community:masterfrom
Closed
[Merged by Bors] - feat(Algebra/ModuleCat): lemma for projective dimension eq zero #37351Thmoas-Guan wants to merge 6 commits intoleanprover-community:masterfrom
Thmoas-Guan wants to merge 6 commits intoleanprover-community:masterfrom
Conversation
PR summary 6ef8cc2731Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
joelriou
reviewed
Apr 2, 2026
Comment on lines
+100
to
+103
| apply ((projectiveDimension_le_iff M 0).mpr inferInstance).antisymm | ||
| ((projectiveDimension_ge_iff M 0).mpr _) | ||
| rw [hasProjectiveDimensionLT_zero_iff_isZero, ModuleCat.isZero_iff_subsingleton] | ||
| exact not_subsingleton_iff_nontrivial.mpr ‹_› |
Contributor
There was a problem hiding this comment.
Could you add and use the following general lemma?
lemma projectiveDimension_eq_zero_iff (X : C) :
projectiveDimension X = 0 ↔ Projective X ∧ ¬ Limits.IsZero X := by
rw [← projectiveDimension_eq_bot_iff, projective_iff_hasProjectiveDimensionLT_one,
← projectiveDimension_lt_iff]
refine ⟨fun h ↦ by simp [h], fun ⟨h₁, h₂⟩ ↦ ?_⟩
generalize h : projectiveDimension X = d
induction d with
| bot => aesop
| coe d => induction d <;> aesop
Collaborator
Author
There was a problem hiding this comment.
I think we have <0 iff = \bot for WithBot ENat, I'll update to see whether it works correctly.
Collaborator
Author
There was a problem hiding this comment.
I added Projective iff HasProjectiveDimensionLE _ 0 for convenience, what do you think about the current proof?
joelriou
reviewed
Apr 3, 2026
Contributor
|
Thanks! bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Apr 4, 2026
Projective dimension of nontrivial projective module is zero. And fix namespace for related lemmas.
Contributor
|
Pull request successfully merged into master. Build succeeded:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Projective dimension of nontrivial projective module is zero.
And fix namespace for related lemmas.