Skip to content

[Merged by Bors] - chore: rename isSuccLimit_iffisSuccLimit_iff_of_orderBot#37410

Closed
vihdzp wants to merge 1 commit intoleanprover-community:masterfrom
vihdzp:isSuccLimit_iff
Closed

[Merged by Bors] - chore: rename isSuccLimit_iffisSuccLimit_iff_of_orderBot#37410
vihdzp wants to merge 1 commit intoleanprover-community:masterfrom
vihdzp:isSuccLimit_iff

Conversation

@vihdzp
Copy link
Copy Markdown
Collaborator

@vihdzp vihdzp commented Mar 31, 2026

I've been bitten a few times by trying to apply this lemma in orders where it's not applicable.


Open in Gitpod

@vihdzp vihdzp added the t-order Order theory label Mar 31, 2026
@vihdzp vihdzp requested a review from YaelDillies March 31, 2026 07:50
@github-actions
Copy link
Copy Markdown

PR summary 4ec5d95aa6

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ isPredLimit_iff
+ isSuccLimit_iff_of_orderBot
+--+ isSuccLimit_iff

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Copy link
Copy Markdown
Contributor

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🚀

maintainer merge

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 1, 2026

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

@mathlib-triage mathlib-triage bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Apr 1, 2026
@Vierkantor Vierkantor self-assigned this Apr 2, 2026
@Vierkantor
Copy link
Copy Markdown
Contributor

Makes sense to me!

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Apr 2, 2026
I've been bitten a few times by trying to apply this lemma in orders where it's not applicable.
@mathlib-triage mathlib-triage bot added ready-to-merge This PR has been sent to bors. and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Apr 2, 2026
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Apr 2, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: rename isSuccLimit_iffisSuccLimit_iff_of_orderBot [Merged by Bors] - chore: rename isSuccLimit_iffisSuccLimit_iff_of_orderBot Apr 2, 2026
@mathlib-bors mathlib-bors bot closed this Apr 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-order Order theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants