Skip to content

[Merged by Bors] - chore: remove an instance diamond in homotopy groups#37485

Closed
sgouezel wants to merge 1 commit intoleanprover-community:masterfrom
sgouezel:SG_lintHomotopy
Closed

[Merged by Bors] - chore: remove an instance diamond in homotopy groups#37485
sgouezel wants to merge 1 commit intoleanprover-community:masterfrom
sgouezel:SG_lintHomotopy

Conversation

@sgouezel
Copy link
Copy Markdown
Contributor

@sgouezel sgouezel commented Apr 1, 2026

With the current definition, CommGroup.toGroup of a homotopy group is not defeq to its group structure. We fix this by reordering parameters in EckmannHilton.commGroup to make sure that the projection to group is definitional.


Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 1, 2026

PR summary 83b8b5c245

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@fpvandoorn
Copy link
Copy Markdown
Member

bors merge

@mathlib-triage mathlib-triage bot added the ready-to-merge This PR has been sent to bors. label Apr 1, 2026
mathlib-bors bot pushed a commit that referenced this pull request Apr 1, 2026
With the current definition, `CommGroup.toGroup` of a homotopy group is not defeq to its group structure. We fix this by reordering parameters in `EckmannHilton.commGroup` to make sure that the projection to group is definitional.

Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Apr 1, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: remove an instance diamond in homotopy groups [Merged by Bors] - chore: remove an instance diamond in homotopy groups Apr 1, 2026
@mathlib-bors mathlib-bors bot closed this Apr 1, 2026
xroblot pushed a commit to xroblot/mathlib4 that referenced this pull request Apr 3, 2026
…unity#37485)

With the current definition, `CommGroup.toGroup` of a homotopy group is not defeq to its group structure. We fix this by reordering parameters in `EckmannHilton.commGroup` to make sure that the projection to group is definitional.

Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants