[Merged by Bors] - chore: remove an instance diamond in homotopy groups#37485
Closed
sgouezel wants to merge 1 commit intoleanprover-community:masterfrom
Closed
[Merged by Bors] - chore: remove an instance diamond in homotopy groups#37485sgouezel wants to merge 1 commit intoleanprover-community:masterfrom
sgouezel wants to merge 1 commit intoleanprover-community:masterfrom
Conversation
PR summary 83b8b5c245Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
Member
|
bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Apr 1, 2026
With the current definition, `CommGroup.toGroup` of a homotopy group is not defeq to its group structure. We fix this by reordering parameters in `EckmannHilton.commGroup` to make sure that the projection to group is definitional. Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr>
Contributor
|
Pull request successfully merged into master. Build succeeded:
|
xroblot
pushed a commit
to xroblot/mathlib4
that referenced
this pull request
Apr 3, 2026
…unity#37485) With the current definition, `CommGroup.toGroup` of a homotopy group is not defeq to its group structure. We fix this by reordering parameters in `EckmannHilton.commGroup` to make sure that the projection to group is definitional. Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the current definition,
CommGroup.toGroupof a homotopy group is not defeq to its group structure. We fix this by reordering parameters inEckmannHilton.commGroupto make sure that the projection to group is definitional.