Skip to content

feat(Combinatorics/SimpleGraph/Sum): add homomorphism, embedding and isomorphism of sums#37495

Open
IvanRenison wants to merge 7 commits intoleanprover-community:masterfrom
IvanRenison:Iso.sum
Open

feat(Combinatorics/SimpleGraph/Sum): add homomorphism, embedding and isomorphism of sums#37495
IvanRenison wants to merge 7 commits intoleanprover-community:masterfrom
IvanRenison:Iso.sum

Conversation

@IvanRenison
Copy link
Copy Markdown
Collaborator


Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 1, 2026

PR summary 6a7332dd00

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ Embedding.sum
+ Embedding.sum_comp_sumAssoc
+ Embedding.sum_comp_sumComm
+ Embedding.toHom_sum
+ Hom.sum
+ Hom.sum_comp_sumAssoc
+ Hom.sum_comp_sumComm
+ Iso.sumCongr
+ Iso.sumCongr_comp_sumAssoc
+ Iso.sumCongr_comp_sumComm
+ Iso.toEmbedding_sumCongr
+ Iso.toHom_sumCongr

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-combinatorics Combinatorics label Apr 1, 2026
Copy link
Copy Markdown
Contributor

@mkaratarakis mkaratarakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! @YaelDillies could take a look please?

@YaelDillies YaelDillies added the awaiting-author A reviewer has asked the author a question or requested changes. label Apr 2, 2026
@IvanRenison IvanRenison removed the awaiting-author A reviewer has asked the author a question or requested changes. label Apr 2, 2026
@YaelDillies YaelDillies added the awaiting-author A reviewer has asked the author a question or requested changes. label Apr 2, 2026
@IvanRenison IvanRenison removed the awaiting-author A reviewer has asked the author a question or requested changes. label Apr 2, 2026
Copy link
Copy Markdown
Contributor

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm tempted to call these sumMap to distinguish from the similar operations based on Sum.elim.

Could you also show these commute (in the appropriate sense) with Equiv.sumComm,
Equiv.sumAssoc?

@YaelDillies YaelDillies added the awaiting-author A reviewer has asked the author a question or requested changes. label Apr 3, 2026
@IvanRenison
Copy link
Copy Markdown
Collaborator Author

@YaelDillies you mean that they commute with Iso.sumComm and Iso.sumAssoc?

@YaelDillies
Copy link
Copy Markdown
Contributor

Something like that, yes

@IvanRenison
Copy link
Copy Markdown
Collaborator Author

I did it, although I'm not sure about the names

@IvanRenison IvanRenison removed the awaiting-author A reviewer has asked the author a question or requested changes. label Apr 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-combinatorics Combinatorics

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants