Skip to content

[Merged by Bors] - feat(Analysis/InnerProductSpace/Reproducing): lemmata for reproducing kernels#37533

Closed
TJHeeringa wants to merge 12 commits intoleanprover-community:masterfrom
TJHeeringa:reproducing_kernel_lemmata
Closed

[Merged by Bors] - feat(Analysis/InnerProductSpace/Reproducing): lemmata for reproducing kernels#37533
TJHeeringa wants to merge 12 commits intoleanprover-community:masterfrom
TJHeeringa:reproducing_kernel_lemmata

Conversation

@TJHeeringa
Copy link
Copy Markdown
Contributor

@TJHeeringa TJHeeringa commented Apr 2, 2026


These are several lemmata regarding pointwise properties of reproducing kernels.

norm_le_sq_norm_mul_diag and norm_sq_le_norm_mul_diag follow from Cauchy-Schwartz on kerFun but are expressed in terms of the kernel. The names contain diag because a kernel is an infinite dimension matrix and thus kernel H x x and kernel H y y are diagonal elements.

zero_row_iff_zero_diag and zero_col_iff_zero_diag have the same proof. One implies the other due to the kernel being Hermitian.

AI:
I wrote the proofs myself, and then asked Claude to compact them because they were too long and I could see that they could be shortened. It gave some good suggestions but mostly broke the proofs, so fixed and compacted it myself (taking into account its useful suggestions).

Open in Gitpod

@github-actions github-actions bot added the new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! label Apr 2, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 2, 2026

Welcome new contributor!

Thank you for contributing to Mathlib! If you haven't done so already, please review our contribution guidelines, as well as the style guide and naming conventions. In particular, we kindly remind contributors that we have guidelines regarding the use of AI when making pull requests.

We use a review queue to manage reviews. If your PR does not appear there, it is probably because it is not successfully building (i.e., it doesn't have a green checkmark), has the awaiting-author tag, or another reason described in the Lifecycle of a PR. The review dashboard has a dedicated webpage which shows whether your PR is on the review queue, and (if not), why.

If you haven't already done so, please come to https://leanprover.zulipchat.com/, introduce yourself, and mention your new PR.

Thank you again for joining our community.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 2, 2026

PR summary 39328e9cd8

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ adjoint_comp_self_eq_zero_iff
+ norm_kerFun_eq_sqrt_norm_kernel
+ norm_kernel_eq_norm_kerFun_sq
+ norm_kernel_le
+ norm_kernel_sq_le

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-analysis Analysis (normed *, calculus) label Apr 2, 2026
TJHeeringa and others added 2 commits April 2, 2026 15:21
Co-authored-by: Monica Omar <23701951+themathqueen@users.noreply.github.com>
@TJHeeringa
Copy link
Copy Markdown
Contributor Author

I updated the implicit {x} to explicit (x) as you suggested. I did this also in the norm_kernel_eq_zero_iff you didn't highlight. I hope that that is correct.

Copy link
Copy Markdown
Collaborator

@themathqueen themathqueen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the first four (or maybe all?) of your results should have H explicit. But I'm not entirely sure. Maybe someone else has an opinion on this.

@TJHeeringa
Copy link
Copy Markdown
Contributor Author

I think the first four (or maybe all?) of your results should have H explicit. But I'm not entirely sure. Maybe someone else has an opinion on this.

You mean because the results apply to the kernel of H, and there is not something else that really fixes H for you?
It makes sense in a way to have it explicit because of that. I hadn't done so, because the existing results already in the file have a similar construction but they have H implicit.

@themathqueen
Copy link
Copy Markdown
Collaborator

You mean because the results apply to the kernel of H, and there is not something else that really fixes H for you?

Yup. But let's wait for another opinion on this

Co-authored-by: Monica Omar <23701951+themathqueen@users.noreply.github.com>
@Maldooor
Copy link
Copy Markdown
Contributor

Maldooor commented Apr 6, 2026

You mean because the results apply to the kernel of H, and there is not something else that really fixes H for you? It makes sense in a way to have it explicit because of that. I hadn't done so, because the existing results already in the file have a similar construction but they have H implicit.

I think kerFun_apply, kernel_apply, kernel_inner and kerFun_dense not having H be explicit was just an oversight by me so they should probably be me made to have H explicit alongside the lemmas you wrote.

@YaelDillies YaelDillies changed the title feat(Analysis/InnerProductSpace/Reproducing): Lemmata for reproducing kernels feat(Analysis/InnerProductSpace/Reproducing): lemmata for reproducing kernels Apr 6, 2026
Copy link
Copy Markdown
Collaborator

@themathqueen themathqueen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good. Just two small comments.

maintainer delegate?

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 6, 2026

🚀 Pull request has been placed on the maintainer queue by themathqueen.

@mathlib-triage mathlib-triage bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Apr 6, 2026
Copy link
Copy Markdown
Contributor

@j-loreaux j-loreaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Apr 6, 2026

✌️ TJHeeringa can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@mathlib-triage mathlib-triage bot added delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Apr 6, 2026
@TJHeeringa
Copy link
Copy Markdown
Contributor Author

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Apr 6, 2026
… kernels (#37533)

Co-authored-by: Heeringa <t.j.heeringa@utwente.nl>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Apr 6, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Analysis/InnerProductSpace/Reproducing): lemmata for reproducing kernels [Merged by Bors] - feat(Analysis/InnerProductSpace/Reproducing): lemmata for reproducing kernels Apr 6, 2026
@mathlib-bors mathlib-bors bot closed this Apr 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! t-analysis Analysis (normed *, calculus)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants