Skip to content

chore(Combinatorics/SimpleGraph/Coloring): move ConcreteColorings.lean and EdgeLabeling.lean to Coloring/#37544

Open
SnirBroshi wants to merge 4 commits intoleanprover-community:masterfrom
SnirBroshi:chore/simple-graph/coloring/move-concrete-and-labeling
Open

chore(Combinatorics/SimpleGraph/Coloring): move ConcreteColorings.lean and EdgeLabeling.lean to Coloring/#37544
SnirBroshi wants to merge 4 commits intoleanprover-community:masterfrom
SnirBroshi:chore/simple-graph/coloring/move-concrete-and-labeling

Conversation

@SnirBroshi
Copy link
Copy Markdown
Collaborator

@SnirBroshi SnirBroshi commented Apr 2, 2026

Moves SimpleGraph/ConcreteColorings.lean to SimpleGraph/Coloring/Constructions.lean
and SimpleGraph/EdgeLabeling.lean to SimpleGraph/Coloring/EdgeLabeling.lean.

See Zulip


Zulip might want to rename ConcreteColorings (Edit: the poll chose Constructions.lean)

#37546 adds module deprecations

Open in Gitpod

@SnirBroshi SnirBroshi added the awaiting-zulip There is a Zulip discussion; the author should await and report/implement the decision reached there label Apr 2, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 2, 2026

PR summary 63868fe5ba

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.Combinatorics.SimpleGraph.ConcreteColorings -990
Mathlib.Combinatorics.SimpleGraph.EdgeLabeling -570
Mathlib.Combinatorics.SimpleGraph.Coloring.EdgeLabeling 570
Mathlib.Combinatorics.SimpleGraph.Coloring.Constructions 990

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

note: file Mathlib/Combinatorics/SimpleGraph/EdgeLabeling.lean` was renamed to `Mathlib/Combinatorics/SimpleGraph/Coloring/EdgeLabeling.lean without a module deprecation
Please create a follow-up pull request adding one. Thanks!

note: file Mathlib/Combinatorics/SimpleGraph/ConcreteColorings.lean` was renamed to `Mathlib/Combinatorics/SimpleGraph/Coloring/Constructions.lean without a module deprecation
Please create a follow-up pull request adding one. Thanks!

@SnirBroshi SnirBroshi removed the awaiting-zulip There is a Zulip discussion; the author should await and report/implement the decision reached there label Apr 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

file-removed A Lean module was (re)moved without a `deprecated_module` annotation t-combinatorics Combinatorics

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant