Skip to content

[Merged by Bors] - feat: union/intersection lemmas for DirSupInacc/DirSupClosed#37639

Closed
vihdzp wants to merge 5 commits intoleanprover-community:masterfrom
vihdzp:dirsupsome
Closed

[Merged by Bors] - feat: union/intersection lemmas for DirSupInacc/DirSupClosed#37639
vihdzp wants to merge 5 commits intoleanprover-community:masterfrom
vihdzp:dirsupsome

Conversation

@vihdzp
Copy link
Copy Markdown
Collaborator

@vihdzp vihdzp commented Apr 4, 2026


Open in Gitpod

@vihdzp vihdzp requested a review from b-mehta April 4, 2026 18:17
@vihdzp vihdzp added the t-order Order theory label Apr 4, 2026
@github-actions github-actions bot added the large-import Automatically added label for PRs with a significant increase in transitive imports label Apr 4, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 4, 2026

PR summary 53f40a86f2

Import changes exceeding 2%

% File
+4.79% Mathlib.Order.DirSupClosed

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.Order.DirSupClosed 355 372 +17 (+4.79%)
Import changes for all files
Files Import difference
Mathlib.Order.DirSupClosed 17

Declarations diff

+ DirSupClosed.empty
+ DirSupClosed.iInter
+ DirSupClosed.sInter
+ DirSupClosed.univ
+ DirSupClosedOn.empty
+ DirSupClosedOn.iInter
+ DirSupClosedOn.inter
+ DirSupClosedOn.sInter
+ DirSupClosedOn.univ
+ DirSupInacc.empty
+ DirSupInacc.iUnion
+ DirSupInacc.sUnion
+ DirSupInacc.univ
+ DirSupInaccOn.empty
+ DirSupInaccOn.iUnion
+ DirSupInaccOn.sUnion
+ DirSupInaccOn.union
+ DirSupInaccOn.univ

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Copy link
Copy Markdown
Contributor

@b-mehta b-mehta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to have the iUnion/iInter versions alongside the sInter and sUnion versions, but thanks for this!

bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Apr 4, 2026

✌️ vihdzp can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@mathlib-triage mathlib-triage bot added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Apr 4, 2026
@vihdzp
Copy link
Copy Markdown
Collaborator Author

vihdzp commented Apr 4, 2026

I've added indexed union/intersection versions :)
bors r+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Apr 4, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: union/intersection lemmas for DirSupInacc/DirSupClosed [Merged by Bors] - feat: union/intersection lemmas for DirSupInacc/DirSupClosed Apr 4, 2026
@mathlib-bors mathlib-bors bot closed this Apr 4, 2026
@vihdzp vihdzp deleted the dirsupsome branch April 5, 2026 00:14
riccardobrasca pushed a commit to riccardobrasca/mathlib4 that referenced this pull request Apr 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). large-import Automatically added label for PRs with a significant increase in transitive imports t-order Order theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants