Skip to content

feat: add warning for non-portable module names#13318

Open
wkrozowski wants to merge 2 commits intoleanprover:masterfrom
wkrozowski:wojciech/forbidden_module_names
Open

feat: add warning for non-portable module names#13318
wkrozowski wants to merge 2 commits intoleanprover:masterfrom
wkrozowski:wojciech/forbidden_module_names

Conversation

@wkrozowski
Copy link
Copy Markdown
Contributor

This PR adds a check for OS-forbidden names and characters in module names. This implements the functionality of modulesOSForbidden linter of mathlib.

@wkrozowski wkrozowski added the changelog-language Language features and metaprograms label Apr 8, 2026
@wkrozowski
Copy link
Copy Markdown
Contributor Author

!bench

@leanprover-radar
Copy link
Copy Markdown

leanprover-radar commented Apr 8, 2026

Benchmark results for b71df8f against e44351a are in. There are no significant changes. @wkrozowski

  • build//instructions: -4.2M (-0.00%)

Small changes (1🟥)

  • 🟥 build/module/Lean.Elab.Import//instructions: +326.5M (+13.47%) (reduced significance based on *//lines)

@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Apr 8, 2026
@mathlib-lean-pr-testing
Copy link
Copy Markdown

mathlib-lean-pr-testing bot commented Apr 8, 2026

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase e44351add937efe4d286669ccd4c33023ca2e60e --onto 4f6bcc5adac8d6234a9e3def3675402cb89823c6. You can force Mathlib CI using the force-mathlib-ci label. (2026-04-08 08:31:03)
  • ❗ Mathlib CI can not be attempted yet, as the nightly-testing-2026-04-02 tag does not exist there yet. We will retry when you push more commits. If you rebase your branch onto nightly-with-mathlib, Mathlib CI should run now. You can force Mathlib CI using the force-mathlib-ci label. (2026-04-08 16:06:45)

@leanprover-bot
Copy link
Copy Markdown
Collaborator

leanprover-bot commented Apr 8, 2026

Reference manual CI status:

  • ❗ Reference manual CI will not be attempted unless your PR branches off the nightly-with-manual branch. Try git rebase e44351add937efe4d286669ccd4c33023ca2e60e --onto 861bc19e0c1c45b5766cc5c9ef0488568368b236. You can force reference manual CI using the force-manual-ci label. (2026-04-08 08:31:04)
  • ✅ Reference manual branch lean-pr-testing-13318 has successfully built against this PR. (2026-04-08 16:13:21) View Log
  • 🟡 Reference manual branch lean-pr-testing-13318 build against this PR didn't complete normally. (2026-04-08 16:14:15) View Log
  • ✅ Reference manual branch lean-pr-testing-13318 has successfully built against this PR. (2026-04-09 11:06:31) View Log
  • 🟡 Reference manual branch lean-pr-testing-13318 build against this PR didn't complete normally. (2026-04-09 11:07:29) View Log

@wkrozowski wkrozowski marked this pull request as ready for review April 8, 2026 10:09
@wkrozowski wkrozowski force-pushed the wojciech/forbidden_module_names branch from b71df8f to 32908e2 Compare April 8, 2026 14:57
leanprover-bot added a commit to leanprover/reference-manual that referenced this pull request Apr 8, 2026
@leanprover-bot leanprover-bot added the builds-manual CI has verified that the Lean Language Reference builds against this PR label Apr 8, 2026
leanprover-bot added a commit to leanprover/reference-manual that referenced this pull request Apr 9, 2026
@wkrozowski wkrozowski force-pushed the wojciech/forbidden_module_names branch from 214a994 to 4428954 Compare April 9, 2026 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

builds-manual CI has verified that the Lean Language Reference builds against this PR changelog-language Language features and metaprograms toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants