feat: warn when simp theorem LHS has variable or unrecognized head symbol#13325
Open
wkrozowski wants to merge 6 commits intoleanprover:masterfrom
Open
feat: warn when simp theorem LHS has variable or unrecognized head symbol#13325wkrozowski wants to merge 6 commits intoleanprover:masterfrom
wkrozowski wants to merge 6 commits intoleanprover:masterfrom
Conversation
|
Mathlib CI status (docs):
|
Collaborator
|
Reference manual CI status:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds warnings when registering
@[simp]theorems whose left-hand side has a problematic head symbol in the discrimination tree:.starkey): The theorem will be tried on everysimpstep, which can be expensive. The warning notes this may be acceptable forlocalorscopedsimp lemmas. Controlled bywarning.simp.varHead(default:true)..otherkey, e.g. a lambda expression): The theorem is unlikely to ever be applied bysimp. Controlled bywarning.simp.otherHead(default:true).