refactor: generalize setInlineAttribute from MetaM to CoreM#13328
Open
MavenRain wants to merge 1 commit intoleanprover:masterfrom
Open
refactor: generalize setInlineAttribute from MetaM to CoreM#13328MavenRain wants to merge 1 commit intoleanprover:masterfrom
MavenRain wants to merge 1 commit intoleanprover:masterfrom
Conversation
This PR changes the type of `Lean.Meta.setInlineAttribute` from `MetaM Unit` to `CoreM Unit`. The function body only uses `getEnv`, `setEnv`, and `throwError`, all of which are available in `CoreM`. All existing call sites are in `MetaM` or monads lifting from it, so no call-site changes are needed. Closes leanprover#4965
MavenRain
changed the title
github-actions
bot
added
the
toolchain-available
|
Mathlib CI status (docs):
|
Collaborator
|
Reference manual CI status:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the type of
Lean.Meta.setInlineAttributefromMetaM UnittoCoreM Unit. The function body only usesgetEnv,setEnv, andthrowError, all of which are available inCoreM. All existing call sites are inMetaMor monads lifting from it, so no call-site changes are needed.Closes #4965