Skip to content

fix: backward defeq types compat fixes for bv_decide#13345

Draft
hargoniX wants to merge 10 commits intomasterfrom
hbv/todo_fix
Draft

fix: backward defeq types compat fixes for bv_decide#13345
hargoniX wants to merge 10 commits intomasterfrom
hbv/todo_fix

Conversation

@hargoniX
Copy link
Copy Markdown
Contributor

@hargoniX hargoniX commented Apr 9, 2026

  • chore: add implicit_reducible/expose attributes to preparatory definitions
  • test: update tests for defeq changes
  • chore: add implicit_reducible/expose attributes to library definitions
  • feat: enable backward.isDefEq.respectTransparency.types by default
  • test: update tests for defeq changes
  • systematic fix 1
  • dsimp to simp
  • change cast
  • more simp
  • fix lrat checker

leodemoura and others added 10 commits April 7, 2026 18:43
…tions

This PR adds `implicit_reducible` and/or `expose` attributes to definitions
that need to be unfolded during defeq checking without full transparency.
Preparatory commit for removing the TODO workaround in ExprDefEq.lean.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Apr 9, 2026
@leanprover-bot
Copy link
Copy Markdown
Collaborator

Reference manual CI status:

  • ❗ Reference manual CI can not be attempted yet, as the nightly-testing-2026-04-06 tag does not exist there yet. We will retry when you push more commits. If you rebase your branch onto nightly-with-manual, reference manual CI should run now. You can force reference manual CI using the force-manual-ci label. (2026-04-09 10:48:00)

mathlib-nightly-testing bot pushed a commit to leanprover-community/batteries that referenced this pull request Apr 9, 2026
@github-actions github-actions bot added the mathlib4-nightly-available A branch for this PR exists at leanprover-community/mathlib4-nightly-testing:lean-pr-testing-NNNN label Apr 9, 2026
mathlib-nightly-testing bot pushed a commit to leanprover-community/mathlib4-nightly-testing that referenced this pull request Apr 9, 2026
@mathlib-lean-pr-testing mathlib-lean-pr-testing bot added the breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan label Apr 9, 2026
@mathlib-lean-pr-testing
Copy link
Copy Markdown

Mathlib CI status (docs):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan mathlib4-nightly-available A branch for this PR exists at leanprover-community/mathlib4-nightly-testing:lean-pr-testing-NNNN toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants