Skip to content

Add maven publish task for common and fido2-core modules#62

Merged
kj84park merged 1 commit intoline:mainfrom
gibeom-gwon:maven-publish
Apr 16, 2025
Merged

Add maven publish task for common and fido2-core modules#62
kj84park merged 1 commit intoline:mainfrom
gibeom-gwon:maven-publish

Conversation

@gibeom-gwon
Copy link
Copy Markdown
Collaborator

What is this PR for?

Publish common and fido2-core modules into user-defined maven repository.

Overview or reasons

  • Ease to publish core modules into maven repository and use it.

Tasks

  • Add gradle script for maven publication.
  • Define publish.maven.url, publish.maven.username, publish.maven.password properties.

Result

  • Publish artifacts by running command below:
./gradlew publish \
-Ppublish.maven.url={Repo URL} \
-Ppublish.maven.username={username} \
-Ppublish.maven.password={password}

Artifacts will be published as com.linecorp.line.auth.fido.fido2:{common,fido2-core}

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Apr 1, 2025

CLA assistant check
All committers have signed the CLA.

Publish common and fido2-core modules into user-defined maven repo by running below command.
./gradlew publish -Ppublish.maven.url={Repo URL} \
-Ppublish.maven.username={username} \
-Ppublish.maven.password={password}

Artifacts will be published as com.linecorp.line.auth.fido.fido2:{common,fido2-core}
@kj84park kj84park self-requested a review April 16, 2025 06:23
Copy link
Copy Markdown
Member

@kj84park kj84park left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. LGTM!

@kj84park kj84park merged commit 2f9ff08 into line:main Apr 16, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants