Skip to content

feat: make frontiers.encode deterministic #714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zxch3n merged 2 commits into from
Apr 14, 2025
Merged

feat: make frontiers.encode deterministic #714

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bbce511
feat: make frontiers.encode deterministic
zxch3n Apr 10, 2025
4d17eae
test: update test case
zxch3n Apr 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion crates/loro-internal/src/version/frontiers.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,8 @@ impl Frontiers {

#[inline]
pub fn encode(&self) -> Vec<u8> {
let vec: Vec<ID> = self.iter().collect();
let mut vec: Vec<ID> = self.iter().collect();
vec.sort();
postcard::to_allocvec(&vec).unwrap()
}

Expand Down
2 changes: 1 addition & 1 deletion crates/loro-wasm/tests/basic.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -695,8 +695,8 @@ it("can query pending txn length", () => {

it("can encode/decode frontiers", () => {
const frontiers = [
{ peer: "1123", counter: 1 },
{ peer: "222", counter: 2 },
{ peer: "1123", counter: 1 },
] as Frontiers;
const encoded = encodeFrontiers(frontiers);
const decoded = decodeFrontiers(encoded);
Expand Down