feat: add convert nat-domain-name to nat-ip at the start of neko#489
feat: add convert nat-domain-name to nat-ip at the start of neko#489Cr34t1ngH0p3 wants to merge 1 commit intom1k1o:masterfrom
Conversation
|
Looks good, but NAT1TO1 in Pion WebRTC is a list of two element: IPv4 and IPv6. So adding multiple domains and resolving them would also need this fix: #47 You could argue that user could add two domains, one that has only A record and another that has only AAAA record, but the whole option seems very counter-intuitive currently and would need a proper refactor with the support of multiple IPs/hostnames. |
Hey, thank you. But tbh, I am not understanding the issue 100%. Does multiple IPs end in an issue, or the combination of IP4 and IP6? And if I read domain names and transfer them to IPs, does that change anything at this issue? |
|
I would work for the first domain only. So the PR is correct, your implementation is actually good. Its just the underlying feature that is confusing. And my idea was, when we are already touching it, it could be refactored entirely. |
Hi, I read this #402 and #247 . In my case it was already helpful if at least at the start I could provide some domainname. Please provide some feedback if it is also useful for you. :)
Best