Open
Conversation
Since a wind sensor may not be installed in alignment, this PR adds the --calibration option to add an offset to the wind_direction. The conversion of wind_direction to windAngle has been corrected so that it is correctly negative for a port angle. The calculations assumes that 360 degree heading will be given for a sensor without a compass. The inclusion of navigation.attitude fields has been made conditional on the compass being turned on. The TODO of "Improve path naming" has been implemented by allowing an address to be pass in, which defaults to a sanitized segment based on the name and location
Author
|
This is not yet tested, as I cannot get near to my sensor for a few days. |
Author
|
Ha, the BLE just reaches my boat on the mooring from the shore! so I was able to test. Looks like it is working as intended: |
Since a wind sensor may not be installed in alignment, this PR adds the --calibration option to add an offset to the wind_direction. The conversion of wind_direction to windAngle has been corrected so that it is correctly negative for a port angle. The calculations assumes that 360 degree heading will be given for a sensor without a compass. The inclusion of navigation.attitude fields has been made conditional on the compass being turned on. The TODO of "Improve path naming" has been implemented by allowing an address to be pass in, which defaults to a sanitized segment based on the name and location
Author
|
I modified it to not use ':' in the battery name: batteries values are now in databrowser:
|
Since a wind sensor may not be installed in alignment, this PR adds the --calibration option to add an offset to the wind_direction. The conversion of wind_direction to windAngle has been corrected so that it is correctly negative for a port angle. The calculations assumes that 360 degree heading will be given for a sensor without a compass. The inclusion of navigation.attitude fields has been made conditional on the compass being turned on. The TODO of "Improve path naming" has been implemented by allowing an address to be pass in, which defaults to a sanitized segment based on the name and location
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since a wind sensor may not be installed in alignment, this PR adds the --calibration option to add an offset to the wind_direction.
The conversion of wind_direction to windAngle has been corrected so that it is correctly negative for a port angle. The calculations assumes that 360 degree heading will be given for a sensor without a compass.
The inclusion of navigation.attitude fields has been made conditional on the compass being turned on.
The TODO of "Improve path naming" has been implemented by allowing an address to be pass in, which defaults to a sanitized segment based on the name and location