-
Notifications
You must be signed in to change notification settings - Fork 107
Add meilisearch target version and logic
#2035
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
flevi29
wants to merge
22
commits into
meilisearch:main
Choose a base branch
from
flevi29:lock-meiliserach-version
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
d251586
Add meilisearch target version and logic
flevi29 1b81635
Fix image version
flevi29 7c761aa
Minor adjustments
flevi29 a21e498
Make setup fully handle docker service, other minor changes
flevi29 022f73f
Merge branch 'main' into lock-meiliserach-version
flevi29 22f0445
Check if there's already a reachable Meilisearch instance before doin…
flevi29 ab3e528
Merge branch 'lock-meiliserach-version' of github.com:flevi29/meilise…
flevi29 b2f37ab
Fix logic
flevi29 30b5a7d
Fix missing api key
flevi29 2b4ff99
Merge with main
flevi29 fb66a42
Misc
flevi29 50ab135
Make sure separate service isn't set up
flevi29 3458284
Minor improvements
flevi29 2db3aa5
Fix issue with parsing args by not doing it
flevi29 b2db904
Misc
flevi29 821e922
Going with .env approach instead
flevi29 28b0290
Use global setup injection instead of env access in tests
flevi29 5f6ce65
Fix wrong port, add details to CONTRIBUTING.md, make all workflows work
flevi29 7eb8213
Remove erroneous 'needs' in pre release workflow
flevi29 6534292
Use a non-env name file instead for config, and use that directly ins…
flevi29 ff4c578
Fix setup CI file
flevi29 64e5fdc
Add validation for environment variables
flevi29 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| # This is a configuration file for both docker and Node.js, | ||
| # and it is meant to be committed and version controlled. | ||
|
|
||
| # The target version of Meilisearch client | ||
| TARGET_VERSION="1.37.0" | ||
|
|
||
| # The port at which the Meilisearch client will be served | ||
| PORT=7700 | ||
|
|
||
| # Meilisearch client master key | ||
| MASTER_KEY="masterKey" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,23 +1,9 @@ | ||
| services: | ||
| package: | ||
| image: node:22 | ||
| tty: true | ||
| stdin_open: true | ||
| working_dir: /home/package | ||
| environment: | ||
| - MEILISEARCH_URL=http://meilisearch:7700 | ||
| depends_on: | ||
| - meilisearch | ||
| links: | ||
| - meilisearch | ||
| volumes: | ||
| - ./:/home/package | ||
|
|
||
| meilisearch: | ||
| image: getmeili/meilisearch-enterprise:v1.37.0 | ||
| image: getmeili/meilisearch-enterprise:v${TARGET_VERSION} | ||
| ports: | ||
| - "7700:7700" | ||
| - "${PORT}:7700" | ||
| environment: | ||
| - MEILI_MASTER_KEY=masterKey | ||
| - MEILI_MASTER_KEY=${MASTER_KEY} | ||
| - MEILI_NO_ANALYTICS=true | ||
| - MEILI_EXPERIMENTAL_ALLOWED_IP_NETWORKS=any |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,14 +1,8 @@ | ||
| { | ||
| "name": "meilisearch-js-playground", | ||
| "private": true, | ||
| "version": "0.0.0", | ||
| "type": "module", | ||
| "scripts": { | ||
| "dev": "vite", | ||
| "build": "vite build", | ||
| "preview": "vite preview" | ||
| }, | ||
| "devDependencies": { | ||
| "vite": "^6.0.11" | ||
| "dev": "vite --open" | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,3 @@ | ||
| /// <reference types="vite/client" /> | ||
| declare const __MASTER_KEY__: string; | ||
| declare const __PORT__: string; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| import { env, loadEnvFile } from "node:process"; | ||
| import { defineConfig } from "vite"; | ||
|
|
||
| loadEnvFile(new URL("../../.conf", import.meta.url)); | ||
| const { MASTER_KEY, PORT } = env; | ||
| if (MASTER_KEY === undefined || PORT === undefined) { | ||
| throw new Error("MASTER_KEY and/or PORT environment variables missing", { | ||
| cause: { MASTER_KEY, PORT }, | ||
| }); | ||
| } | ||
|
|
||
| export default defineConfig({ | ||
| server: { host: "127.0.0.1" }, | ||
| define: Object.fromEntries( | ||
| Object.entries({ PORT, MASTER_KEY }).map(([key, val]) => [ | ||
| `__${key}__`, | ||
| JSON.stringify(val), | ||
| ]), | ||
| ), | ||
| }); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.