Add disableOnNumbers option to typo tolerance settings#506
Add disableOnNumbers option to typo tolerance settings#506claudeaceae wants to merge 2 commits intomeilisearch:mainfrom
Conversation
Implements support for the disableOnNumbers field in typo tolerance settings, introduced in Meilisearch v1.15. This allows users to deactivate typo tolerance on numeric terms. Closes meilisearch#480 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
📝 WalkthroughWalkthroughAdds support for a new typo tolerance setting Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Sherlouk
left a comment
There was a problem hiding this comment.
Minor comment, otherwise LGTM
Per reviewer feedback, update the disableOnNumbers code sample to use modern async/await syntax instead of callbacks. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Updated the code sample to use async/await — thanks for the feedback! I'll use that style going forward. |
Summary
disableOnNumbersfield toTypoToleranceandTypoToleranceResultmodelstypo_tolerance_guide_5code sample for the documentationCloses #480
Related issue
Implements [Meilisearch v1.15] Add
disableOnNumbersto typo tolerance settings (#480)What does this PR do?
Adds support for the
disableOnNumberstypo tolerance setting introduced in Meilisearch v1.15. This allows users to deactivate typo tolerance on numeric terms (high entropy words).Changes
TypoTolerance.swift: AddeddisableOnNumbers: Bool?property and updated initializerTypoToleranceResult.swift: AddeddisableOnNumbers: BoolpropertytestUpdateTypoToleranceDisableOnNumbersdefaultTypoToleranceResultto includedisableOnNumbers.code-samples.meilisearch.yaml: Addedtypo_tolerance_guide_5code samplePR checklist
mainbranchtypo_tolerance_guide_5Summary by CodeRabbit
New Features
Tests
Documentation