Skip to content

chore: update ranking rules tests for v1.36.0#509

Open
Strift wants to merge 1 commit intomainfrom
chore/update-tests-for-v1.36.0
Open

chore: update ranking rules tests for v1.36.0#509
Strift wants to merge 1 commit intomainfrom
chore/update-tests-for-v1.36.0

Conversation

@Strift
Copy link
Copy Markdown
Contributor

@Strift Strift commented Feb 24, 2026

Pull Request

Related issue

Fixes #508

What does this PR do?

  • Update default ranking rules in tests

PR checklist

Please check if your PR fulfills the following requirements:

  • Did you use any AI tool while implementing this PR (code, tests, docs, etc.)? If yes, disclose it in the PR description and describe what it was used for. AI usage is allowed when it is disclosed.
  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

Summary by CodeRabbit

  • Tests
    • Updated default ranking rules validation in integration tests to ensure test coverage accurately reflects the system's current ranking configuration and expected behavior.

@Strift Strift added the maintenance Anything related to maintenance (CI, tests, refactoring...) label Feb 24, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Feb 24, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d962c64 and 86bfe10.

📒 Files selected for processing (1)
  • Tests/MeiliSearchIntegrationTests/SettingsTests.swift

📝 Walkthrough

Walkthrough

A test file is updated to reflect Meilisearch 1.36.0 API changes, replacing the "attribute" ranking rule with "attributeRank", adding "wordPosition" after "sort", and appending "exactness" to match the new default ranking rules returned by the API.

Changes

Cohort / File(s) Summary
Test Update
Tests/MeiliSearchIntegrationTests/SettingsTests.swift
Updated default ranking rules array in test expectations to align with Meilisearch 1.36.0: replaced "attribute" with "attributeRank", inserted "wordPosition", and added "exactness".

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 The rules have shifted, old to new,
Attribute bows, Rank takes the queue,
Word positions gleam, exactness shines bright,
Tests dance in harmony with the update's light! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title 'chore: update ranking rules tests for v1.36.0' accurately summarizes the main change, which is updating test ranking rules for Meilisearch 1.36.0.
Linked Issues check ✅ Passed The PR updates default ranking rules in tests by replacing 'attribute' with 'attributeRank' and adding 'wordPosition', directly addressing issue #508's requirement to update tests for Meilisearch 1.36.0 API response changes.
Out of Scope Changes check ✅ Passed All changes are scoped to updating test expectations for ranking rules in accordance with Meilisearch 1.36.0 API changes, with no unrelated modifications present.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/update-tests-for-v1.36.0

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Strift Strift added the help wanted Extra attention is needed label Feb 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

help wanted Extra attention is needed maintenance Anything related to maintenance (CI, tests, refactoring...)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update ranking rules test for Meilisearch 1.36.0 API responses

1 participant