Open
Conversation
Collaborator
|
There are still conflicting files so you should resolve conflicts |
Collaborator
|
Also just a thought: maybe we could also show operations near the Meilisearch icon in the toolbar, instead of just showing a big logo? |
Collaborator
|
Also why are there unrelated changes in |
Author
|
The api key needs to be defined, otherwise it fails if the recipe isn't installed (like when working locally). |
Collaborator
|
So when you'll get rid of unrelated changes and resolve conflicts I'll review your PR |
Author
|
Alas, I'm not able to put any more time into this right now.
…On Mon, Jul 1, 2024 at 3:34 AM Tomas Norkūnas ***@***.***> wrote:
So when you'll get rid of unrelated changes and resolve conflicts I'll
review your PR
—
Reply to this email directly, view it on GitHub
<#337 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEXIQP2OWHVUWMYVS2L4ELZKEA6PAVCNFSM6AAAAABKAASO3OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJZGQ2DEMJWGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per #275
To see this in action, make sure meilisearch is running and run the following:
You'll see the meilisearch icon in the toolbar
Click on it to see the debug info