Skip to content

added tests + multiple bug fixes + UTF-8 robustness#17

Open
tilo wants to merge 8 commits intomericson:masterfrom
1debit:bug-fixes
Open

added tests + multiple bug fixes + UTF-8 robustness#17
tilo wants to merge 8 commits intomericson:masterfrom
1debit:bug-fixes

Conversation

@tilo
Copy link
Copy Markdown

@tilo tilo commented Aug 15, 2018

Looks like this gem is unmaintained 😞

If you still need to use it, you might want to consider these updates and fixes:

  • applied all the outstanding PRs of the original gem
  • fixed gemspec file and Rakefile to be modern style
  • removed unused ./test directory
  • added RSpec tests
  • converted RSpec tests to RSpec 3 syntax
  • cleaned up Ruby style
  • fixed and simplified regular expressions
  • fixed parsing so it does not break names with UTF-8 characters!
  • allowing 2nd, 3rd, 4th, Nth
  • added lots of test cases
  • fixed bugs in the parsing
  • stripping spaces from titles and suffixes
  • recognizing double middle names (might require you to do post-processing for double last names)

@tilo tilo changed the title added tests + multiple bug fixes added tests + multiple bug fixes + UTF-8 robustness Aug 15, 2018
@tilo
Copy link
Copy Markdown
Author

tilo commented Aug 15, 2018

it's important to use \p{Word} instead of [A-Za-z] or \w+, so UTF-8 characters are included!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant