Skip to content

quickbuild.sh argument reg_grid or irreg_grid to select ROMS_rutgers model_mod#2

Open
hkershaw-brown wants to merge 1 commit intomgharamti:roms_interpfrom
NCAR:roms_interp_quickbuild
Open

quickbuild.sh argument reg_grid or irreg_grid to select ROMS_rutgers model_mod#2
hkershaw-brown wants to merge 1 commit intomgharamti:roms_interpfrom
NCAR:roms_interp_quickbuild

Conversation

@hkershaw-brown
Copy link
Copy Markdown

Description:

ROMS_rutgers regular grid uses much less memory than the irregular grid (NCAR#1090)
However, ROMS has curvilinear and rotated grids. This pull request adds a compile time option (argument to quickbuild.sh)
to select regular or irregular grid.

regular grid model_mod_reg_grid (NCAR#1090)
irregular grid model_mod_irreg_grid (NCAR/DART v11.22)

Fixes issue

Extension of NCAR#1090

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Documentation changes needed?

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.

Tests

Please describe any tests you ran to verify your changes.

Just building

Checklist for merging

  • Updated changelog entry
  • Documentation updated
  • Update conf.py

Checklist for release

  • Merge into main
  • Create release from the main branch with appropriate tag
  • Delete feature-branch

Testing Datasets

  • Dataset needed for testing available upon request
  • Dataset download instructions included
  • No dataset needed

@hkershaw-brown
Copy link
Copy Markdown
Author

@mgharamti here is what I am thinking for a ROMS_rutgers (optimized reg-grid for Indonesia or other reg cases), but can switch in irregular grid version. Selection is done a quickbuild.sh time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant