Add accepted-controls workflow to remediation report#10
Merged
Conversation
Collaborator
|
@copilot , accepted controls should be saved across runs so the user does not have to keep accepting them. |
Agent-Logs-Url: https://github.com/microsoft/adoqr/sessions/c45b32d4-0fb7-42a3-a41c-060c5c0886af Co-authored-by: aj-enns <6963265+aj-enns@users.noreply.github.com>
Agent-Logs-Url: https://github.com/microsoft/adoqr/sessions/c45b32d4-0fb7-42a3-a41c-060c5c0886af Co-authored-by: aj-enns <6963265+aj-enns@users.noreply.github.com>
Agent-Logs-Url: https://github.com/microsoft/adoqr/sessions/c45b32d4-0fb7-42a3-a41c-060c5c0886af Co-authored-by: aj-enns <6963265+aj-enns@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add functionality for whitelisting a control error
Add accepted-controls workflow to remediation report
May 19, 2026
Agent-Logs-Url: https://github.com/microsoft/adoqr/sessions/5c43313b-3e4b-453f-9863-5d896f0bee03 Co-authored-by: aj-enns <6963265+aj-enns@users.noreply.github.com>
Author
This is already how the remediation report behaves: accepted controls are stored per organization in browser storage and reused by later remediation reports opened in the same browser. I clarified that in the UI and README in 35031fa. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
…ntrols functionality, and update tests - Added semantic versioning guidelines to `copilot-instructions.md`. - Created `CHANGELOG.md` to document project changes and adhere to Keep a Changelog standards. - Introduced a `VERSION` file for version tracking. - Updated `invoke-adoqr.ps1` to include "Undo acceptance" functionality for accepted controls. - Modified executive summary in `invoke-adoqr.ps1` to include recalculation hooks for accepted risks. - Enhanced tests in `ExecutiveHtml.Tests.ps1` to verify new functionality related to accepted controls. - Updated `RemediationHtml.Tests.ps1` to check for "Undo acceptance" in rendered HTML. - Included `Write-ExecutiveHtmlReport` in the bootstrap script for testing.
…icrosoft/adoqr into copilot/whitelist-control-error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

The remediation report could identify control failures, but it had no way to record risk acceptance and remove those items from the active queue. This change adds an explicit accepted-controls workflow with required justification, acceptance date tracking, and a dedicated accepted view.
Remediation workflow
UI/state model
Accessibility and UX
Test/docs updates
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
accounts.google.com/proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=network --no-sandbox --use-angle=swiftshader-webgl --crashpad-handler-pid=5344 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/org.chromium.Chromium.scoped_dir.46f1SR --change-stack-guard-on-fork=enable --shared-files=network_parent_dirs_pipe:100,v8_context_snapshot_data:101 --field-trial-handle=3,i,1193721758381396485,16626853335326604329,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,5312902848347411217,2154463804345275307,4 --trace-process-track-uuid=3190708989122997041(dns block)/usr/bin/chromium chromium --headless --disable-gpu --no-sandbox --window-size=1440,1600 --screenshot=/tmp/adoqr-remediation-accepted.png --virtual-time-budget=3000 file:///tmp/adoqr-remediation-sample-accepted.html(dns block)/proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=network --no-sandbox --use-angle=swiftshader-webgl --crashpad-handler-pid=5462 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/org.chromium.Chromium.scoped_dir.wZ5zW6 --change-stack-guard-on-fork=enable --shared-files=network_parent_dirs_pipe:100,v8_context_snapshot_data:101 --field-trial-handle=3,i,439487259699399466,8333477991589366205,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,5104935401185639191,8941135447521593099,4 --trace-process-track-uuid=3190708989122997041(dns block)clients2.google.com/proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=network --no-sandbox --use-angle=swiftshader-webgl --crashpad-handler-pid=5344 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/org.chromium.Chromium.scoped_dir.46f1SR --change-stack-guard-on-fork=enable --shared-files=network_parent_dirs_pipe:100,v8_context_snapshot_data:101 --field-trial-handle=3,i,1193721758381396485,16626853335326604329,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,5312902848347411217,2154463804345275307,4 --trace-process-track-uuid=3190708989122997041(dns block)/usr/bin/chromium chromium --headless --disable-gpu --no-sandbox --window-size=1440,1600 --screenshot=/tmp/adoqr-remediation-accepted.png --virtual-time-budget=3000 file:///tmp/adoqr-remediation-sample-accepted.html(dns block)/proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=network --no-sandbox --use-angle=swiftshader-webgl --crashpad-handler-pid=5462 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/org.chromium.Chromium.scoped_dir.wZ5zW6 --change-stack-guard-on-fork=enable --shared-files=network_parent_dirs_pipe:100,v8_context_snapshot_data:101 --field-trial-handle=3,i,439487259699399466,8333477991589366205,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,5104935401185639191,8941135447521593099,4 --trace-process-track-uuid=3190708989122997041(dns block)redirector.gvt1.com/proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=network --no-sandbox --use-angle=swiftshader-webgl --crashpad-handler-pid=5344 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/org.chromium.Chromium.scoped_dir.46f1SR --change-stack-guard-on-fork=enable --shared-files=network_parent_dirs_pipe:100,v8_context_snapshot_data:101 --field-trial-handle=3,i,1193721758381396485,16626853335326604329,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,5312902848347411217,2154463804345275307,4 --trace-process-track-uuid=3190708989122997041(dns block)/usr/bin/chromium chromium --headless --disable-gpu --no-sandbox --window-size=1440,1600 --screenshot=/tmp/adoqr-remediation-accepted.png --virtual-time-budget=3000 file:///tmp/adoqr-remediation-sample-accepted.html(dns block)/proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=network --no-sandbox --use-angle=swiftshader-webgl --crashpad-handler-pid=5462 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/org.chromium.Chromium.scoped_dir.wZ5zW6 --change-stack-guard-on-fork=enable --shared-files=network_parent_dirs_pipe:100,v8_context_snapshot_data:101 --field-trial-handle=3,i,439487259699399466,8333477991589366205,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,5104935401185639191,8941135447521593099,4 --trace-process-track-uuid=3190708989122997041(dns block)www.google.com/proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=network --no-sandbox --use-angle=swiftshader-webgl --crashpad-handler-pid=5344 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/org.chromium.Chromium.scoped_dir.46f1SR --change-stack-guard-on-fork=enable --shared-files=network_parent_dirs_pipe:100,v8_context_snapshot_data:101 --field-trial-handle=3,i,1193721758381396485,16626853335326604329,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,5312902848347411217,2154463804345275307,4 --trace-process-track-uuid=3190708989122997041(dns block)/usr/bin/chromium chromium --headless --disable-gpu --no-sandbox --window-size=1440,1600 --screenshot=/tmp/adoqr-remediation-accepted.png --virtual-time-budget=3000 file:///tmp/adoqr-remediation-sample-accepted.html(dns block)/proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=network --no-sandbox --use-angle=swiftshader-webgl --crashpad-handler-pid=5462 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/org.chromium.Chromium.scoped_dir.wZ5zW6 --change-stack-guard-on-fork=enable --shared-files=network_parent_dirs_pipe:100,v8_context_snapshot_data:101 --field-trial-handle=3,i,439487259699399466,8333477991589366205,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,5104935401185639191,8941135447521593099,4 --trace-process-track-uuid=3190708989122997041(dns block)If you need me to access, download, or install something from one of these locations, you can either: