FullSync Initiate Check when at least one sync session is still active.#1193
Merged
vazois merged 2 commits intomicrosoft:mainfrom May 8, 2025
Merged
FullSync Initiate Check when at least one sync session is still active.#1193vazois merged 2 commits intomicrosoft:mainfrom
vazois merged 2 commits intomicrosoft:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR ensures that a full streaming snapshot is initiated only when at least one sync session requires a full synchronization. The changes include:
- Updating the test case to wait for the replica to catch up after validating replica data.
- Modifying the DisklessReplication manager to have PrepareForSync return a boolean indicating whether a full sync is required.
- Introducing a boolean flag within PrepareForSync to conditionally trigger the streaming checkpoint.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/Garnet.test.cluster/ReplicationTests/ClusterReplicationDisklessSyncTests.cs | Added wait functionality for replica AOF synchronization in the test. |
| libs/cluster/Server/Replication/PrimaryOps/DisklessReplication/ReplicationSyncManager.cs | Changed PrepareForSync to return a boolean and conditionally trigger the streaming checkpoint based on active sync sessions. |
Comments suppressed due to low confidence (1)
libs/cluster/Server/Replication/PrimaryOps/DisklessReplication/ReplicationSyncManager.cs:219
- [nitpick] Consider renaming the method 'PrepareForSync' to better reflect its boolean return value (e.g., 'ShouldPerformFullSync') to improve code clarity.
async Task<bool> PrepareForSync()
badrishc
approved these changes
May 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ensures that streaming snapshot is initiated only one at least one sync session requires fully synchronization.