WIP: ci/cd: Run e2e helm tests separately#3162
Conversation
| // Helm tests are executed in their own environment | ||
| matchedE2EHelmTests := FilterLabelsContain(matchedE2ETests, "helm-") | ||
| matchedE2ETests = FilterLabelsDoNotContain(matchedE2ETests, "helm-") | ||
|
|
||
| // Government tests are executed in their own environment | ||
| matchedE2EGovTests := FilterLabelsContain(matchedE2ETests, "atlas-gov") | ||
| matchedE2ETests = FilterLabelsDoNotContain(matchedE2ETests, "atlas-gov") | ||
|
|
||
| matchedIntTestsJSON, _ := json.Marshal(matchedIntTests) | ||
| matchedE2ETestsJSON, _ := json.Marshal(matchedE2ETests) | ||
| matchedE2E2TestsJSON, _ := json.Marshal(matchedE2E2Tests) | ||
| matchedE2EGovTestsJSON, _ := json.Marshal(matchedE2EGovTests) | ||
| matchedE2EHelmTestsJSON, _ := json.Marshal(matchedE2EHelmTests) |
There was a problem hiding this comment.
nit: we could simplify this tool and its extensibility a lot if we did not have dedicated hardwire families but instead pass FAMILY=e2e2 and LABELS=... don't you think?
There was a problem hiding this comment.
even better:
FAMILIES=e2e,int,e2e2 and LABELS
you can have a table of "allowed families" and most code becomes loops over selected families.
AI can refactor that in a jiffy probably
|
This PR has gone 30 days without any activity and meets the project’s definition of 'stale'. This will be auto-closed if there is no new activity over the next 60 days. If the issue is still relevant and active, you can simply comment with a 'bump' to keep it open. Thanks for keeping our repository healthy! |
|
Will get back to this one as part of the help duty |
|
This PR has gone 30 days without any activity and meets the project’s definition of 'stale'. This will be auto-closed if there is no new activity over the next 60 days. If the issue is still relevant and active, you can simply comment with a 'bump' to keep it open. Thanks for keeping our repository healthy! |
Summary
This PR makes any e2e test which label starts with "helm-" to be treated as helm test and run in separately from regular e2e tests
Checklist