Draft
Conversation
jtroberts
reviewed
Feb 7, 2025
| "VIIRS_NOAA21_CorrectedReflectance_TrueColor", | ||
| "VIIRS_NOAA21_CorrectedReflectance_BandsM3-I3-M11", | ||
| "VIIRS_NOAA21_CorrectedReflectance_BandsM11-I2-I1", | ||
| "VIIRS_VNP46A1_LERC_v1", |
Member
There was a problem hiding this comment.
We should rename this layer to maybe VIIRS_SNPP_DayNightBand_LERC.
Collaborator
Author
There was a problem hiding this comment.
I agree and I will change once we ingest more data under that ID since the ID here is used for the imagery requests
I updated the add more imagery ticket to include this new ID
…change to VIIRS_SNPP_DayNightBand_At_Sensor_Radiance_LERC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE THAT THIS IS STILL A WIP: Megan needs to add VIIRS and OMI lerc layers to worldview endpoints so I can remove some of this ugly hardcoding stuff
Right now, I am accessing the lerc layers by running Joe's ec2 instance and using localhost, so we need to publish the lerc layers
Once the LERC layer is added to the official endpoints, we can get the snapshot that matches the rest of the snapshots by running
npm run buildwhich gets the snapshot with a request to https://wvs.earthdata.nasa.gov/api/v1/snapshotI am keeping the incorrect
web/images/layers/previews/geographic/VIIRS_VNP46A1_LERC_v1.jpgin this PR as a reminder for nowWe also need to update the legend images for both layers
I also still need to create tests that the LERC layers are showing up properly
I added OMI data as
OMI_Total_NO2_LRC_v1in measurements/Nitrogen Dioxide/Aura/OMI. If this is not a good placement for the layer, I also found measurements/aerosol_index /aura/OMI and measurements/ozone/aura/OMIDescription
Adds the LERC decoder to worldview so that LERC layers are now supported. Some other notes:
drawTilewas for comparing the average/ difference between 2 layers. The closest feature in worldview was comparison mode which is just displaying 2 layers normally but side by sideWe agreed this was okay in a meeting 2/4/2025
drawTile(which is the case if the user altered the layer thresholds), then don’t show values above or below the current thresholdThings discussed but were resolved:
We should add this documentation somewhere too:
Steps to add a layer worldview
config/default/common/config/wv.json/measurements/Earth at Night.json)
worldview/tasks/build-options/extractConfigFromWMTS.js
Lines 121 to 123 in b983eb3
worldview/tasks/build-options/getVisMetadata.js
Lines 163 to 186 in b983eb3
[Description of the bug or feature]
[If this is a relatively large or complex change, start a discussion by explaining why you chose the solution you did and what alternatives you considered, etc...]
Potential discussion topics in bullets above
How To Test
[Provide whatever information a reviewer might need to know in order to verify that the changes made in this PR are working as expected. If there are special build steps that need to be taken in order to get these changes to run (building while on a separate branch, running
npm ci, etc) include them here.]Can now open VIIRS Nighttime Imagery LERC layer to the map and view it. This LERC layer should have all functionality like changing the palette, min/max values, and opacity. All other layers and behavior should function the same
I verified that I could delete my local copy of worldview and rebuild/ run
PR Submission Checklist
This is simply a reminder of what we are going to look for before merging your code.
Merging
Please use the
squash and mergecommit method unless each commit in your branch is vital to the commit history of main.@nasa-gibs/worldview