WV-4029: Convert App component from class to functional#6562
Merged
vicgonzalez25 merged 2 commits intodevelopfrom Apr 10, 2026
Merged
WV-4029: Convert App component from class to functional#6562vicgonzalez25 merged 2 commits intodevelopfrom
vicgonzalez25 merged 2 commits intodevelopfrom
Conversation
vicgonzalez25
requested review from
Tomcariello,
ZachTRice,
christof-wittreich,
jwhurley1 and
minniewong
Tomcariello
approved these changes
Apr 9, 2026
christof-wittreich
requested changes
Apr 9, 2026
christof-wittreich
approved these changes
Apr 10, 2026
jwhurley1
approved these changes
Apr 10, 2026
christof-wittreich
added a commit
that referenced
this pull request
Apr 10, 2026
* Dependency Updates 04-03-26 (#6559) * Added tasks/bamboo/runUnitTest.sh * Updated comments to be accurate * Added empty placeholder unit test files * PlayQueue functional component (#6565) * WV-4029: Convert App component from class to functional (#6562) * WV-4029: Convert App component from class to functional * Replace what-input library with native CSS :focus-visible * Dependency Updates 04-10-26 (#6577) * v4.94.0 --------- Co-authored-by: Jason Hurley <95651563+jwhurley1@users.noreply.github.com> Co-authored-by: Jason Hurley <jwhurley1@gmail.com> Co-authored-by: vicgonzalez25 <victor.a.gonzalez-leon@nasa.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Converts the top-level
Appcomponent in web/js/app.js from a class to a functional component with hooks.What changed
onload()startup logic → one-timeuseEffect(still wrapped inutil.wrap)componentDidMount/componentWillUnmount→ singleuseEffectfor thekeydown,resize, andorientationchangelisteners with cleanupcomponentDidUpdatewatcher onnumberOutagesUnseen→useEffect+usePreviousfrom customHooks.jsstatic setVhCSSProperty→ module-level constwhat-inputlibrary — replaced[data-whatintent]selectors in reset.scss and toolbar.scss with native CSS:focus-visible