IMUF 257 support

[nerdCopter]

• IMUF 257 is not yet merged. up for testing only.

Summary by CodeRabbit

• New Features
  • IMUF filters are now version-aware: v256 can output header and effective (PTN-scaled) curves; v257+ outputs a single configured cutoff without PTN scaling.
  • Automatically detects IMUF version from input and applies behavior per axis.
  • Diagnostic output labels curves with IMUF version and shows version-specific details.
• Tests
  • Added tests for version parsing, curve generation, and PTN scaling to validate v256 vs v257+ behavior.

[coderabbitai]

📝 Walkthrough

Walkthrough

Introduces IMUF version awareness in filter response generation and parsing. Adds a version field to ImufFilterConfig, parses version from headers (default 256), and branches curve generation between v256 (header/effective with PTN scaling) and v257+ (single configured cutoff). Updates logging to reflect version-specific behavior and extends tests accordingly.

Changes

Cohort / File(s)	Change summary
IMUF version-aware filtering src/data_analysis/filter_response.rs	Added ImufFilterConfig.version (u32); propagated version during parsing; generate_individual_filter_curves branches for v256 vs v257+ (PTN scaling only for v256); updated logging/diagnostics; tests extended to cover parsing and curve generation semantics for both versions.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

• feat: Add mathematically correct filter response curves to spectrum plots #36 — Also modifies src/data_analysis/filter_response.rs to introduce IMUF version handling and curve-generation branching.
• feat: Add EmuFlight HELIOSPRING IMUF v256 filter support with visual distinction #52 — Earlier IMUF work in the same module; this PR extends it by adding a version field and version-specific logic.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title “IMUF 257 support” succinctly captures the primary change of adding support for IMUF revision 257 in the filter response logic without extraneous detail, making it clear and focused for anyone scanning the commit history.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch 20251004_support_IMUF_257

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 47decf0 and 096407b.

📒 Files selected for processing (1)

• src/data_analysis/filter_response.rs (9 hunks)

🧰 Additional context used

🧠 Learnings (1)

📓 Common learnings

Learnt from: nerdCopter
PR: nerdCopter/BlackBox_CSV_Render#55
File: LICENSE_COMMERCIAL:1-7
Timestamp: 2025-09-10T13:56:40.607Z
Learning: nerdCopter prefers to use minimal commercial license templates that are consistent across his projects, similar to what was used in the bbl_parser repository PR #2.

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Test and Lint

🔇 Additional comments (1)

src/data_analysis/filter_response.rs (1)

231-287: IMUF version gating looks correct.

v256 keeps the header/effective split with PTN scaling while v257+ collapses to the configured cutoff, matching the firmware behavior. Nicely done.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[nerdCopter]

imuf 257 wrong: emuflight/imu-f#17 (comment)