NLB-7404: Add custom directives for NGINXaaS usecase#170
NLB-7404: Add custom directives for NGINXaaS usecase#170Naveen-Gopu-F5 wants to merge 2 commits intonginxinc:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #170 +/- ##
==========================================
+ Coverage 76.63% 78.51% +1.87%
==========================================
Files 27 32 +5
Lines 1164 1182 +18
==========================================
+ Hits 892 928 +36
+ Misses 216 201 -15
+ Partials 56 53 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
I don't think nginx-go-crossplane is a good place for this; these are NGINXaaS specific directives and we don't want to affect other users of nginx-go-crossplane.
Can we move this one file into the NGINXaaS repo, and add it to our crossplane configuration? All the C, JSON, plumbing aren't really needed. We know the shape of the directives we want to add and we can specify that directly.
|
closing this PR, since we will be making changes in our NGINXaaS repo. |
Proposed changes
Usecase :
NGINXaaS for Azure need 2 new custom directives (pseudo directives) which we will be using for the VMSS backend support feature. Since these directives are not part of nginx we want to add parsing, analyzing rules for these 2 new directives.
We will be using those in our control plane part and not in dataplane where actual nginx configuration applies and uses them.
nginxaas-scaling-group: This directive specifies the resource_id of the user's VMSS (Example : /subscriptions//resourceGroups//providers/Microsoft.Compute/virtualMachineScaleSets/)nginxaas-scaling-group: This directive specifies some of the configuration details.Describe the use case and detail of the change. If this PR addresses an issue on GitHub, make sure to include a link to that issue using one of the supported keywords here in this description (not in the title of the PR).
Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentREADME.md)