Update directive map for max_headers#174
Merged
ryepup merged 1 commit intonginxinc:mainfrom Apr 13, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #174 +/- ##
==========================================
+ Coverage 76.63% 78.20% +1.56%
==========================================
Files 27 31 +4
Lines 1164 1179 +15
==========================================
+ Hits 892 922 +30
+ Misses 216 202 -14
+ Partials 56 55 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ornj
approved these changes
Apr 8, 2026
Member
ornj
left a comment
There was a problem hiding this comment.
{ ngx_string("max_headers"),
NGX_HTTP_MAIN_CONF|NGX_HTTP_SRV_CONF|NGX_CONF_TAKE1,
ngx_conf_set_num_slot,
NGX_HTTP_SRV_CONF_OFFSET,
offsetof(ngx_http_core_srv_conf_t, max_headers),
NULL },Add the max_headers directive entry to match the upstream NGINX change. The directive limits the number of request headers and is valid in the http and server contexts with a single argument.
4e872e8 to
2a430e7
Compare
ryepup
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the max_headers directive entry to match the upstream NGINX change. The directive limits the number of request headers and is valid in the http and server contexts with a single argument.
Proposed changes
Updates the
nginx-go-crossplanedirective map to include the newmax_headersdirective, which was backported from freenginx into mainline NGINX. The directive is valid in thehttpandservercontexts and takes a single argument. This is a companion change for the NGINX backport of themax_headersdirective.Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentREADME.md)