Skip to content

Update directive map for max_headers#174

Merged
ryepup merged 1 commit intonginxinc:mainfrom
dekobon:cherry/added-max-headers-directive
Apr 13, 2026
Merged

Update directive map for max_headers#174
ryepup merged 1 commit intonginxinc:mainfrom
dekobon:cherry/added-max-headers-directive

Conversation

@dekobon
Copy link
Copy Markdown
Contributor

@dekobon dekobon commented Apr 8, 2026

Add the max_headers directive entry to match the upstream NGINX change. The directive limits the number of request headers and is valid in the http and server contexts with a single argument.

Proposed changes

Updates the nginx-go-crossplane directive map to include the new max_headers directive, which was backported from freenginx into mainline NGINX. The directive is valid in the http and server contexts and takes a single argument. This is a companion change for the NGINX backport of the max_headers directive.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md)

@dekobon dekobon requested a review from a team as a code owner April 8, 2026 19:55
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.20%. Comparing base (eaaaa89) to head (2a430e7).
⚠️ Report is 34 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #174      +/-   ##
==========================================
+ Coverage   76.63%   78.20%   +1.56%     
==========================================
  Files          27       31       +4     
  Lines        1164     1179      +15     
==========================================
+ Hits          892      922      +30     
+ Misses        216      202      -14     
+ Partials       56       55       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@ornj ornj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right to me.

    { ngx_string("max_headers"),
      NGX_HTTP_MAIN_CONF|NGX_HTTP_SRV_CONF|NGX_CONF_TAKE1,
      ngx_conf_set_num_slot,
      NGX_HTTP_SRV_CONF_OFFSET,
      offsetof(ngx_http_core_srv_conf_t, max_headers),
      NULL },

Add the max_headers directive entry to match the upstream NGINX
change.  The directive limits the number of request headers and
is valid in the http and server contexts with a single argument.
@dekobon dekobon force-pushed the cherry/added-max-headers-directive branch from 4e872e8 to 2a430e7 Compare April 8, 2026 21:04
@ryepup ryepup merged commit c450382 into nginxinc:main Apr 13, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants