Skip to content

⚡ Bolt: Optimize file content aggregation in get_files.py#824

Open
georgi wants to merge 6 commits intomainfrom
bolt/optimize-get-files-17395407827527284964
Open

⚡ Bolt: Optimize file content aggregation in get_files.py#824
georgi wants to merge 6 commits intomainfrom
bolt/optimize-get-files-17395407827527284964

Conversation

@georgi
Copy link
Copy Markdown
Contributor

@georgi georgi commented Apr 4, 2026

💡 What: Refactored get_files and get_content in src/nodetool/io/get_files.py to use list-based accumulation instead of string/list concatenation.
🎯 Why: Iterative string concatenation (content += new_string) in Python creates a new string every time, leading to O(N²) time complexity. "".join(list) runs in O(N).
📊 Impact: Significant reduction in time and memory allocation when generating large concatenated source files across many paths.
🔬 Measurement: Verify tests run perfectly with uv run pytest tests/io/test_get_files.py.


PR created automatically by Jules for task 17395407827527284964 started by @georgi

Replaced iterative string concatenation in `get_content` with a list `append` and `"".join()` pattern to solve an O(N^2) bottleneck. Also updated `get_files` to use `list.extend` rather than list concatenation. Added unit tests for these utilities.

Co-authored-by: georgi <19498+georgi@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

google-labs-jules bot and others added 5 commits April 4, 2026 10:43
Replaced iterative string concatenation in `get_content` with a list `append` and `"".join()` pattern to solve an O(N^2) bottleneck. Also updated `get_files` to use `list.extend` rather than list concatenation. Added unit tests for these utilities.

Co-authored-by: georgi <19498+georgi@users.noreply.github.com>
Replaced iterative string concatenation in `get_content` with a list `append` and `"".join()` pattern to solve an O(N^2) bottleneck. Also updated `get_files` to use `list.extend` rather than list concatenation. Added unit tests for these utilities.

Co-authored-by: georgi <19498+georgi@users.noreply.github.com>
Replaced iterative string concatenation in `get_content` with a list `append` and `"".join()` pattern to solve an O(N^2) bottleneck. Also updated `get_files` to use `list.extend` rather than list concatenation. Added unit tests for these utilities.

Co-authored-by: georgi <19498+georgi@users.noreply.github.com>
Replaced iterative string concatenation in `get_content` with a list `append` and `"".join()` pattern to solve an O(N^2) bottleneck. Also updated `get_files` to use `list.extend` rather than list concatenation. Added unit tests for these utilities.

Co-authored-by: georgi <19498+georgi@users.noreply.github.com>
Replaced iterative string concatenation in `get_content` with a list `append` and `"".join()` pattern to solve an O(N^2) bottleneck. Also updated `get_files` to use `list.extend` rather than list concatenation. Added unit tests for these utilities.

Co-authored-by: georgi <19498+georgi@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant