tests: Add test for DFU upload an image#635
Merged
nvlsianpu merged 1 commit intonrfconnect:mainfrom Feb 10, 2026
Merged
Conversation
github-actions
Bot
added
the
changelog-entry-required
michalek-no
approved these changes
Feb 3, 2026
|
You can find the documentation preview for this PR here. |
fundakol
force-pushed
the
tests/bm-installer-upload-too-large-app
branch
from
f097e33 to
5089f0a
Compare
jumi-nordic
approved these changes
Feb 3, 2026
jumi-nordic
left a comment
jumi-nordic
left a comment
There was a problem hiding this comment.
LGTM with minor fixes needed:
- Typos in docstrings
- var type
- temp files cleanup
| ) | ||
|
|
||
| assert expand_hex_file(str(tmp_hex_path), str(output_hex), partition_size, extra_size), ( | ||
| f"Cannot expand the hex file: {tmp_hex_path}" |
There was a problem hiding this comment.
The test creates temporary files but doesn't clean them up. Consider adding cleanup logic
Contributor
Author
There was a problem hiding this comment.
Temporary files are managed by pytest. They are not deleted at the end of session, but pytest keeps only 3 last versions and deletes the oldest one when runs a new session. It helps with debugging when you need to check a temporary file after run. Also as those files are created in /tmp folder there will be deleted after restart of PC or a docker.
eivindj-nordic
approved these changes
Feb 3, 2026
fundakol
force-pushed
the
tests/bm-installer-upload-too-large-app
branch
from
5089f0a to
d255390
Compare
Added test for uploading too large application image. Signed-off-by: Lukasz Fundakowski <lukasz.fundakowski@nordicsemi.no>
fundakol
force-pushed
the
tests/bm-installer-upload-too-large-app
branch
from
d255390 to
1c53d60
Compare
nvlsianpu
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added test for uploading too large application image.