Skip to content

bm_zms: fix a bug in case of read after a write#778

Merged
eivindj-nordic merged 1 commit intonrfconnect:mainfrom
rghaddab:rghaddab/fix-read-after-write
Apr 28, 2026
Merged

bm_zms: fix a bug in case of read after a write#778
eivindj-nordic merged 1 commit intonrfconnect:mainfrom
rghaddab:rghaddab/fix-read-after-write

Conversation

@rghaddab
Copy link
Copy Markdown
Contributor

When a read is triggered immediately after a write it can start just after a sector is closed and picks up the wrong address to start the search from.
Fix this by storing a backup read address before closing a sector.

@rghaddab rghaddab requested a review from a team as a code owner April 27, 2026 09:36
@github-actions github-actions Bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Apr 27, 2026
@rghaddab rghaddab force-pushed the rghaddab/fix-read-after-write branch from 52eb5e4 to 3cdeff3 Compare April 27, 2026 09:38
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Apr 27, 2026

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link
Copy Markdown

You can find the documentation preview for this PR here.

@rghaddab rghaddab requested review from anhmolt and lemrey April 27, 2026 09:48
Copy link
Copy Markdown
Contributor

@anhmolt anhmolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the issues I have been seeing. See and address my one comment and we will try to merge this tomorrow.

We need a changelog entry, but Iet us take that in #779.

Comment thread subsys/fs/bm_zms/bm_zms.c Outdated
When a read is triggered immediately after a write it can start just
after a sector is closed and picks up the wrong address to start the
search from.
Fix this by storing a backup read address before closing a sector.

Signed-off-by: Riadh Ghaddab <riadh.ghaddab@nordicsemi.no>
@rghaddab rghaddab force-pushed the rghaddab/fix-read-after-write branch from 3cdeff3 to 1cc328f Compare April 27, 2026 14:10
@anhmolt anhmolt modified the milestone: v2.0.0 Apr 27, 2026
@anhmolt anhmolt removed changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Apr 27, 2026
@eivindj-nordic eivindj-nordic merged commit 9732e4e into nrfconnect:main Apr 28, 2026
20 checks passed
@eivindj-nordic eivindj-nordic added the doc-postponed PR requires documentation updates, tech writer review happens later. label Apr 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-postponed PR requires documentation updates, tech writer review happens later.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants