bluetooth: hrs: change hrm_encode return type to uint16_t#780
Open
PizzaAllTheWay wants to merge 1 commit intonrfconnect:mainfrom
Open
bluetooth: hrs: change hrm_encode return type to uint16_t#780PizzaAllTheWay wants to merge 1 commit intonrfconnect:mainfrom
PizzaAllTheWay wants to merge 1 commit intonrfconnect:mainfrom
Conversation
hrm_encode() returned uint8_t, but both places that use it expect a uint16_t (ble_gatts_attr_t.init_len and ble_gatts_hvx_params_t.p_len from the SoftDevice API). In practice the length never goes above 255, so this was not a real bug, just an inconsistency that forced the compiler to silently widen the value. Changing the return type (and the internal len variable) to uint16_t makes everything line up. No functional change. Signed-off-by: Martynas Smilingis <martynas.smilingis@nordicsemi.no>
github-actions
Bot
added
the
changelog-entry-required
|
You can find the documentation preview for this PR here. |
eivindj-nordic
approved these changes
Apr 28, 2026
eivindj-nordic
removed
the
changelog-entry-required
Contributor
|
Static function, no changelog required. |
anhmolt
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hrm_encode() returned uint8_t, but both places that use it expect a uint16_t (ble_gatts_attr_t.init_len and ble_gatts_hvx_params_t.p_len from the SoftDevice API).
In practice the length never goes above 255, so this was not a real bug, just an inconsistency that forced the compiler to silently widen the value. Changing the return type (and the internal len variable) to uint16_t makes everything line up.
No functional change.