update /api/delete to use POST method instead of DELETE #178
Draft
nguu0123 wants to merge 2 commits intoollama:mainfrom
Draft
update /api/delete to use POST method instead of DELETE #178nguu0123 wants to merge 2 commits intoollama:mainfrom
nguu0123 wants to merge 2 commits intoollama:mainfrom
Conversation
Member
|
Hi @nguu0123 thanks for the first-time contribution, I appreciate that you thought of the SDKs when you saw the issue in the main repo. This isn't implemented in the main ollama repo, and I doubt it will be for some time if it does get picked up, having a POST to delete a model feels a bit confusing to me. I'm going to mark this as a draft for now to keep things tidy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to issue 7895 and PR 8018