refactor: replace overloads with generics for streamable methods#268
Open
majiayu000 wants to merge 1 commit intoollama:mainfrom
Open
refactor: replace overloads with generics for streamable methods#268majiayu000 wants to merge 1 commit intoollama:mainfrom
majiayu000 wants to merge 1 commit intoollama:mainfrom
Conversation
Replace function overloads with generic type parameters for methods that accept a stream parameter. This allows the stream parameter to be typed as boolean while still providing correct return type inference. Methods updated: - generate - chat - create - pull - push Fixes ollama#78 Signed-off-by: majiayu000 <1835304752@qq.com>
BruceMacD
reviewed
Jan 5, 2026
Member
BruceMacD
left a comment
There was a problem hiding this comment.
This is looking good, thanks for the contribution. I'll test a bit more once the conflict is resolved.
We should note that this will effect any clients that extend ollama-js for some reason, although I am not aware of anyone using the library like that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
streamparameter to acceptbooleantype while preserving correct return type inferencegenerate,chat,create,pull,pushProblem
When using overloads, passing a
booleanvariable as thestreamparameter caused TypeScript errors due to ambiguity in overload resolution:Solution
Replace overloads with a generic type parameter that defaults to
false:Test plan
Fixes #78