Skip to content

Fix environment variable precedence over default_config_files for subcommands#862

Merged
mauvilsa merged 1 commit intomainfrom
issue-860-subcommands-env-var-override
Mar 3, 2026
Merged

Fix environment variable precedence over default_config_files for subcommands#862
mauvilsa merged 1 commit intomainfrom
issue-860-subcommands-env-var-override

Conversation

@mauvilsa
Copy link
Copy Markdown
Member

@mauvilsa mauvilsa commented Mar 3, 2026

What does this PR do?

Fixes #860

Before submitting

  • Did you read the contributing guideline?
  • [n/a] Did you update the documentation? (readme and public docstrings)
  • Did you write unit tests such that there is 100% coverage on related code? (required for bug fixes and new features)
  • Did you verify that new and existing tests pass locally?
  • Did you make sure that all changes preserve backward compatibility?
  • Did you update the CHANGELOG including a pull request link? (not for typos, docs, test updates, or minor internal changes/refactors)

@mauvilsa mauvilsa added the bug Something isn't working label Mar 3, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (40b8930) to head (fc25043).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #862   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           24        24           
  Lines         7323      7330    +7     
=========================================
+ Hits          7323      7330    +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Mar 3, 2026

@mauvilsa mauvilsa changed the title Fix environment variable precedent over default_config_files for subcommands Fix environment variable precedence over default_config_files for subcommands Mar 3, 2026
@mauvilsa mauvilsa merged commit d37fddd into main Mar 3, 2026
31 checks passed
@mauvilsa mauvilsa deleted the issue-860-subcommands-env-var-override branch March 3, 2026 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

store_true: overriding a configured value with an env var does not work for subcommands

1 participant