Fixed InitialFolder so it now works more than first time its called p… …r. application#1
Closed
buildcomplete wants to merge 2 commits intoookii-dialogs:masterfrom
Closed
Fixed InitialFolder so it now works more than first time its called p… …r. application#1buildcomplete wants to merge 2 commits intoookii-dialogs:masterfrom
buildcomplete wants to merge 2 commits intoookii-dialogs:masterfrom
Conversation
…r. application The dialog.SetDefaultFolder(item) is only set first time the applications sets the folder, Next time the folder will be restored to last picked object and the 'Default folder' is ignored Use instead dialog.SetFolder which behaviour better matches the name 'InitialFolder'
…irectory Fixed InitialFolder so it now works more than first time its called p…
Member
|
Thank you @buildcomplete! Could you please update the pull-request to come from your branch |
Member
|
@buildcomplete I'm not convinced this is a bug. This seems to be a common behavior in several applications... Visual Studio, Notepad, Excel, ... Basically the first time you open the dialog, it points you to the default folder you set. If you switch to different folder than the default one, it remembers what that folder is (in case you want to open more files from that folder, for example). What are your thoughts? |
Author
|
I couldn't change the source in this pull, so I made a new comming from the branch as you mention. #2 |
Member
|
Thanks. Will close this one then, and we can continue the discussion on #2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dialog.SetDefaultFolder(item) is only set first time the applications sets the folder,
Next time the folder will be restored to last picked object and the 'Default folder' is ignored
Use instead dialog.SetFolder which behaviour better matches the name 'InitialFolder'