Skip to content

feat: add imports to h2 MM supply benchmark#604

Open
AndreasHD11 wants to merge 9 commits intomasterfrom
feat/h2-supply-benchmark
Open

feat: add imports to h2 MM supply benchmark#604
AndreasHD11 wants to merge 9 commits intomasterfrom
feat/h2-supply-benchmark

Conversation

@AndreasHD11
Copy link
Copy Markdown
Member

@AndreasHD11 AndreasHD11 commented Apr 2, 2026

Closes #551

Changes proposed in this Pull Request

This PR proposes to add hydrogen imports (ammonia and imports) from the Market Model Outputs data to the benchmarking.

Tasks

Workflow

Open issues

Notes

Test workflow locally run (2013 cy years etc..). Version (0.5.1) on plot comes from test config being run.

2040 csv benchmark:
image

2040 eu27 hydrogen supply plot:
image

2030 DE hydrogen supply plot:
image

Checklist

  • I tested my contribution locally and it works as intended.
  • Code and workflow changes are sufficiently documented.
  • Changed dependencies are added to pixi.toml (using pixi add <dependency-name>).
  • Changes in configuration options are added in config/config.default.yaml.
  • Changes in configuration options are documented in doc/configtables/*.csv.
  • Changes in configuration options are added in config/test/*.yaml.
  • The multiple weather/climate years test is passing locally (using pixi run -e open-tyndp tyndp-cyears-test).
  • Open-TYNDP SPDX license header added to all touched files.
  • For new data sources or versions, these instructions have been followed.
  • New rules are documented in the appropriate doc/*.rst files.
  • A release note doc/release_notes.rst is added.
  • Major features are documented with up-to-date information in README and doc/index.rst.
  • Module docstrings added to new Python scripts.

@AndreasHD11 AndreasHD11 added the SB Scenario Building label Apr 2, 2026
@AndreasHD11 AndreasHD11 requested a review from tgilon April 2, 2026 15:14
Copy link
Copy Markdown
Member

@tgilon tgilon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @AndreasHD11 for this PR! It's a nice added value to the nodal benchmarks.

  • I would suggest using a vectorized approach to clean the dataframe.
  • Could you add a release note to the PR?
  • Could you also add this PR to the list in the README and in doc/index.rst

Comment thread scripts/sb/clean_tyndp_output_benchmark.py Outdated
AndreasHD11 and others added 5 commits April 7, 2026 10:40
Co-authored-by: Thomas Gilon <thomas.gilon@openenergytransition.org>
* doc: prepare release v0.6.1

* doc: bump version

* [github-actions.ci] Update locked envs

* fix: fix typo

* doc: update figures to v0.6.1

---------

Co-authored-by: tgilon <22521851+tgilon@users.noreply.github.com>
@lisazeyen lisazeyen self-requested a review April 10, 2026 08:48
@AndreasHD11 AndreasHD11 removed the request for review from lisazeyen April 16, 2026 12:45
@AndreasHD11 AndreasHD11 requested a review from tgilon April 20, 2026 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

SB Scenario Building

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[SUB] Add H2 imports to the Market Model Outputs data

2 participants